Skip to content

[SYCL][CUDA] Fix selected_binary argument in piextDeviceSelectBinary #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2020
Merged

[SYCL][CUDA] Fix selected_binary argument in piextDeviceSelectBinary #1475

merged 1 commit into from
Apr 7, 2020

Conversation

hiaselhans
Copy link
Contributor

selected_binary argument for piextDeviceSelectBinary should be binary index (pi_uint32)

@hiaselhans
Copy link
Contributor Author

I found that the cuda plugin is using a different signature in piextDeviceSelectBinary than the OpenCL plugin

@hiaselhans
[SYCL][CUDA] fix piextDeviceSelectBinary
f0a97be 
selected_binary argument for piextDeviceSelectBinary should be binary index

Signed-off-by: hiaselhans <[email protected]>
@hiaselhans hiaselhans force-pushed the cuda_select_binary branch from 14dc911 to f0a97be Compare April 3, 2020 17:50
@bader bader requested a review from Ruyk April 3, 2020 17:56
@bader bader added the cuda CUDA back-end label Apr 3, 2020
@hiaselhans hiaselhans changed the title [SYCL][CUDA] fix piextDeviceSelectBinary [SYCL][CUDA] piextDeviceSelectBinary selected_binary argument Apr 3, 2020
@hiaselhans hiaselhans changed the title [SYCL][CUDA] piextDeviceSelectBinary selected_binary argument [SYCL][CUDA] fix selected_binary argument in piextDeviceSelectBinary Apr 3, 2020
@bader bader changed the title [SYCL][CUDA] fix selected_binary argument in piextDeviceSelectBinary [SYCL][CUDA] Fix selected_binary argument in piextDeviceSelectBinary Apr 7, 2020
@bader bader merged commit 3c0a0f1 into intel:sycl Apr 7, 2020
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Apr 9, 2020
Merge remote-tracking branch 'origin/sycl' into private/abatashe/sche…
0032e53 
…duler_docs

* origin/sycl: (26 commits)
  [Driver][SYCL] Move include/sycl header before other system header locations (intel#1492)
  [BuildBot] Improve usability of buildbot scripts (intel#1472)
  [NFC] Add GitHub actions badges to README file (intel#1496)
  [SYCL] Improve error handling for kernel invocation (intel#1209)
  [SYCL][Driver] Fix SYCL standards' handling for '-fsycl -fsycl-device-only' invocations (intel#1371)
  [SYCL] Move type checks to later in Semantic Analysis lifecycle (intel#1465)
  [CI] Download fixed versions of Python tools (intel#1485)
  [SYCL] Fix sub_group::broadcast (intel#1482)
  [SYCL][Test] Disable spec_const_redefine.cpp on all devices but HOST (intel#1488)
  [SYCL] Only export public API (intel#1456)
  [SYCL][CUDA] Fix selected_binary argument in piextDeviceSelectBinary (intel#1475)
  [SYCL] Enable LIT testing with CUDA BE (intel#1458)
  [SYCL] Fix float to half-type conversion (intel#1395)
  [NFC] Cleanup unneded macro from builtins implementation (intel#1445)
  Enable cfg-printer LLVM lit tests only if LLVM linked statically (intel#1479)
  [SYCL][NFC] Reflect the "allowlist" renaming in the code (intel#1480)
  [SYCL][Doc] Update prerequisites in GetStartedGuide (intel#1466)
  [SYCL][USM] Remove vestigial dead code (intel#1474)
  [SYCL-PTX] Fix __spirv_GroupAsyncCopy stride computation (intel#1451)
  [Driver][SYCL] Emit an error if c compilation is forced (intel#1438)
  ...
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Apr 15, 2020
Merge remote-tracking branch 'origin/sycl' into private/abatashe/basi…
961afa4 
…c_abi_checks

* origin/sycl: (625 commits)
  [SYCL][Test] Disable spec_const_redefine.cpp on all devices but HOST (intel#1488)
  [SYCL] Only export public API (intel#1456)
  [SYCL][CUDA] Fix selected_binary argument in piextDeviceSelectBinary (intel#1475)
  [SYCL] Enable LIT testing with CUDA BE (intel#1458)
  [SYCL] Fix float to half-type conversion (intel#1395)
  [NFC] Cleanup unneded macro from builtins implementation (intel#1445)
  Enable cfg-printer LLVM lit tests only if LLVM linked statically (intel#1479)
  [SYCL][NFC] Reflect the "allowlist" renaming in the code (intel#1480)
  [SYCL][Doc] Update prerequisites in GetStartedGuide (intel#1466)
  [SYCL][USM] Remove vestigial dead code (intel#1474)
  [SYCL-PTX] Fix __spirv_GroupAsyncCopy stride computation (intel#1451)
  [Driver][SYCL] Emit an error if c compilation is forced (intel#1438)
  [SYCL] Fix sycl-post-link when no split and symbols are requested. (intel#1454)
  [SYCL] Change priority of devices in default_selector (intel#1264)
  [CI] Update CODEOWNERS matching rules order (intel#1468)
  [SYCL] Share PFWG lambda object through shared memory (intel#1455)
  [CI] Fix CODEOWNERS file syntax (intel#1464)
  [SYCL][CUDA] Fix active context when creating base event (intel#1447)
  [SYCL] Diagnose implicit declaration of kernel function type (intel#1450)
  [BuildBot] Modify configure script (intel#1421)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanovvlad romanovvlad romanovvlad approved these changes

@bader bader Awaiting requested review from bader

@Ruyk Ruyk Awaiting requested review from Ruyk

Assignees

@romanovvlad romanovvlad

Labels
cuda CUDA back-end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hiaselhans @romanovvlad @bader