[SYCL][NFC] Avoid warnings in SYCLSpecConstMaterializer and program_manager #14770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anager This commit avoids the following warnings in post-commit testing: * SYCLSpecConstMaterializer had a loop purely for debug printing. If NDEBUG is defined, the loop variable is unused, which causes a warning. To address this, we mask the debug printing with ifndef NDEBUG. * In program_manager, debug printing now checks whether debug printing is enabled using if constexpr. This now means that getFormatStr is unused, which in turn causes a warning. This commit marks it as potentially unused to avoid this warning. Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
jchlanda
approved these changes
Jul 25, 2024
victor-eds
reviewed
Jul 25, 2024
Signed-off-by: Larsen, Steffen <[email protected]>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
AMD failure appears to be an infrastructural issue. @intel/dpcpp-kernel-fusion-reviewers - Please have a look ASAP. |
|
I've seen the same failure in multiple open PRs: |
sommerlukas
approved these changes
Jul 25, 2024
hdelan
pushed a commit
to hdelan/llvm
that referenced
this pull request
Jul 26, 2024
…anager (intel#14770) This commit avoids the following warnings in post-commit testing: * SYCLSpecConstMaterializer had a loop purely for debug printing. If `NDEBUG` is defined, the loop variable is unused, which causes a warning. To address this, the use of `LLVM_DEBUG` is moved to outside the full debug printing body. * In program_manager, debug printing now checks whether debug printing is enabled using `if constexpr`. This now means that `getFormatStr` is unused, which in turn causes a warning. This commit marks it as potentially unused to avoid this warning. --------- Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit avoids the following warnings in post-commit testing:
NDEBUGis defined, the loop variable is unused, which causes a warning. To address this, the use ofLLVM_DEBUGis moved to outside the full debug printing body.if constexpr. This now means thatgetFormatStris unused, which in turn causes a warning. This commit marks it as potentially unused to avoid this warning.