Skip to content

[NFC] fix build issue in NDEBUG mode #14777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2024
Merged

[NFC] fix build issue in NDEBUG mode #14777

merged 2 commits into from
Jul 25, 2024

Conversation

Naghasan
Copy link
Contributor

No description provided.

@sommerlukas
Copy link
Contributor

@intel/llvm-gatekeepers @sarnex This PR should fix the current post-commit failure, can you please merge when CI is done (or now)?

@sarnex
Copy link
Contributor

sarnex commented Jul 25, 2024

I want at least Windows build to pass (Linux build already did), then I'll merge.

@sarnex
Copy link
Contributor

sarnex commented Jul 25, 2024

Build + LIT passed on both platforms, merging to unbreak CI.

@sarnex sarnex merged commit 4329b0c into intel:sycl Jul 25, 2024
14 checks passed
@sarnex
Copy link
Contributor

sarnex commented Jul 25, 2024

@Naghasan Still failing in postcommit:

https://github.com/intel/llvm/actions/runs/10099057533/job/27927417771

 [6364/8901] Linking CXX shared library lib/libSYCLKernelFusionPasses.so.19.0git
FAILED: lib/libSYCLKernelFusionPasses.so.19.0git 
: && /opt/sycl/bin/clang++ -fPIC -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wl,-z,defs -Wl,-z,nodelete   -Wl,-rpath-link,/__w/llvm/llvm/build/./lib  -Wl,--gc-sections -shared -Wl,-soname,libSYCLKernelFusionPasses.so.19.0git -o lib/libSYCLKernelFusionPasses.so.19.0git tools/sycl-fusion/passes/CMakeFiles/SYCLKernelFusionPasses.dir/SYCLFusionPasses.cpp.o tools/sycl-fusion/passes/CMakeFiles/SYCLKernelFusionPasses.dir/kernel-fusion/Builtins.cpp.o tools/sycl-fusion/passes/CMakeFiles/SYCLKernelFusionPasses.dir/kernel-fusion/SYCLKernelFusion.cpp.o tools/sycl-fusion/passes/CMakeFiles/SYCLKernelFusionPasses.dir/kernel-fusion/SYCLSpecConstMaterializer.cpp.o tools/sycl-fusion/passes/CMakeFiles/SYCLKernelFusionPasses.dir/kernel-info/SYCLKernelInfo.cpp.o tools/sycl-fusion/passes/CMakeFiles/SYCLKernelFusionPasses.dir/internalization/Internalization.cpp.o tools/sycl-fusion/passes/CMakeFiles/SYCLKernelFusionPasses.dir/syclcp/SYCLCP.cpp.o tools/sycl-fusion/passes/CMakeFiles/SYCLKernelFusionPasses.dir/cleanup/Cleanup.cpp.o tools/sycl-fusion/passes/CMakeFiles/SYCLKernelFusionPasses.dir/debug/PassDebug.cpp.o tools/sycl-fusion/passes/CMakeFiles/SYCLKernelFusionPasses.dir/target/TargetFusionInfo.cpp.o  -Wl,-rpath,"\$ORIGIN/../lib:/__w/llvm/llvm/build/lib:"  lib/libLLVMPasses.so.19.0git  lib/libsycl-fusion-common.so.19.0git  lib/libLLVMTransformUtils.so.19.0git  lib/libLLVMCore.so.19.0git  lib/libLLVMTargetParser.so.19.0git  lib/libLLVMSupport.so.19.0git  -Wl,-rpath-link,/__w/llvm/llvm/build/lib && :
/usr/bin/ld: tools/sycl-fusion/passes/CMakeFiles/SYCLKernelFusionPasses.dir/kernel-fusion/SYCLSpecConstMaterializer.cpp.o: in function `llvm::SYCLSpecConstMaterializer::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&)':
SYCLSpecConstMaterializer.cpp:(.text._ZN4llvm25SYCLSpecConstMaterializer3runERNS_8FunctionERNS_15AnalysisManagerIS1_JEEE+0x46): undefined reference to `llvm::TargetHelpers::getArchType(llvm::Module const&)'

@sarnex
Copy link
Contributor

sarnex commented Jul 25, 2024

@sommerlukas Also FYI, not sure if anyone is still in working hours that can work on this

@sarnex
Copy link
Contributor

sarnex commented Jul 25, 2024

I fixed it in #14780

hdelan pushed a commit to hdelan/llvm that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants