Skip to content

[UR] disable hwloc support for UMF #14812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

igchor
Copy link
Member

@igchor igchor commented Jul 26, 2024

Hwloc package is not avalable on certain distros (e.g. RHEL). To avoid forcing users to install hwloc from sources, disable hwloc in UMF.

Based on: oneapi-src/unified-memory-framework#642

@igchor igchor force-pushed the bump_umf_static_hwloc branch from 6957b4a to fda2519 Compare July 26, 2024 20:35
@igchor igchor temporarily deployed to WindowsCILock July 26, 2024 20:36 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock July 26, 2024 21:04 — with GitHub Actions Inactive
Hwloc package is not avalable on certain distros (e.g. RHEL).
To avoid forcing users to install hwloc from sources, disable
hwloc in UMF.
@igchor igchor force-pushed the bump_umf_static_hwloc branch from fda2519 to 159cc42 Compare July 26, 2024 22:05
@igchor igchor temporarily deployed to WindowsCILock July 26, 2024 22:05 — with GitHub Actions Inactive
@igchor igchor temporarily deployed to WindowsCILock July 26, 2024 22:37 — with GitHub Actions Inactive
@pbalcer pbalcer marked this pull request as ready for review July 29, 2024 07:14
@pbalcer pbalcer requested a review from a team as a code owner July 29, 2024 07:14
@pbalcer pbalcer requested a review from dm-vodopyanov July 29, 2024 07:14
@pbalcer pbalcer temporarily deployed to WindowsCILock July 29, 2024 07:14 — with GitHub Actions Inactive
@pbalcer pbalcer temporarily deployed to WindowsCILock July 29, 2024 07:38 — with GitHub Actions Inactive
@pbalcer
Copy link
Contributor

pbalcer commented Jul 29, 2024

@intel/llvm-reviewers-runtime @intel/unified-runtime-reviewers this is ready, please review.

Copy link
Contributor

@maarquitos14 maarquitos14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UR LGTM

@pbalcer
Copy link
Contributor

pbalcer commented Jul 29, 2024

@intel/llvm-gatekeepers please merge

@dm-vodopyanov dm-vodopyanov merged commit 2e2fb43 into intel:sycl Jul 29, 2024
14 checks passed
AlexeySachkov pushed a commit to AlexeySachkov/llvm that referenced this pull request Nov 26, 2024
Hwloc package is not avalable on certain distros (e.g. RHEL). To avoid
forcing users to install hwloc from sources, disable hwloc in UMF.

Based on:
oneapi-src/unified-memory-framework#642

---------

Co-authored-by: Piotr Balcer <[email protected]>
Co-authored-by: Dmitry Vodopyanov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants