Skip to content

[SYCL][DeviceSanitizer] Fix incorrect private shadow range check #14842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 12, 2024
Merged

[SYCL][DeviceSanitizer] Fix incorrect private shadow range check #14842

merged 2 commits into from
Aug 12, 2024

Conversation

al42and
Copy link
Contributor

@al42and al42and commented Jul 30, 2024 •
edited
Loading

A simple typo introduced in #13450

Was causing false-positive [kernel] Private shadow memory out-of-bound errors.

@al42and al42and requested a review from a team as a code owner July 30, 2024 11:29
@al42and
Copy link
Contributor Author

al42and commented Jul 30, 2024

Ping @AllanZyne

AllanZyne
AllanZyne approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@AllanZyne AllanZyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@al42and al42and temporarily deployed to WindowsCILock July 30, 2024 12:18 — with GitHub Actions Inactive
@al42and
Copy link
Contributor Author

al42and commented Jul 31, 2024

CI errors look unrelated:

  • Windows job fails with "rm: cannot remove <...> Device or resource busy", which in the past was solved by rebooting the affected host.
  • Linux job fails due to missing HIP device (or misbehaving drivers).

@AllanZyne
Copy link
Contributor

@intel/llvm-gatekeepers, please merge.
Thanks very much!

@al42and
Copy link
Contributor Author

al42and commented Aug 12, 2024

Ping @intel/llvm-gatekeepers, could this get merged?

@martygrant martygrant merged commit 2578b75 into intel:sycl Aug 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllanZyne AllanZyne AllanZyne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@al42and @AllanZyne @martygrant