Skip to content

[SYCL] Move get_info_host implementation to header #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2020

Conversation

alexbatashev
Copy link
Contributor

@alexbatashev alexbatashev commented Apr 14, 2020

The change allows calls to get_info_host to be inlined.

Signed-off-by: Alexander Batashev [email protected]

romanovvlad
romanovvlad previously approved these changes Apr 14, 2020
Signed-off-by: Alexander Batashev <[email protected]>
@bader bader merged commit e3fefa3 into intel:sycl Apr 15, 2020
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Apr 15, 2020
…c_abi_checks

* origin/sycl: (32 commits)
  [SYCL] Do not force LLVM_INCLUDE_TESTS variable (intel#1505)
  [SYCL][NFC] Align nd_item members with constructor initialization list (intel#1521)
  [SYCL] Move get_info_host implementation to header (intel#1514)
  [SYCL] Always use dynamic CRT for Unit tests (intel#1515)
  [SYCL][NFC] Temporarily disable sporadically failing test (intel#1526)
  [SYCL] Fix inline namespaces (intel#1525)
  [SYCL] Release notes for March'20 DPCPP implementation update (intel#1511)
  [SYCL][PI][CUDA] Implements get_native interoperability (intel#1332)
  [SYCL] Fix check-sycl test suite on systems w/o OpenCL (intel#1503)
  [SYCL][Doc] Update ExtendedAtomics documentation (intel#1487)
  [SYCL][CUDA] Expose context extended deleters on PI API (intel#1483)
  [SYCL][NFC] Remove a dropped environment variable from a test (intel#1506)
  [SYCL] Add opencl-aot to sycl-toolchain target (intel#1504)
  [SYCL] Allow to run deploy LIT tests from particular directory
  [SYCL][CUDA] Fix LIT testing with CUDA devices (intel#1300)
  [SYCL] Remove operator name keywords (intel#1501)
  [Driver][SYCL] Consider .lo files as static archives (intel#1500)
  [SYCL-PTX] Update the compiler design to describe the CUDA target (intel#1408)
  [SYCL] Fix library build on Windows (intel#1499)
  [SYCL][NFC] Refactor lit.cfg.py (intel#1452)
  ...
@alexbatashev alexbatashev deleted the private/abatashe/inline_get_info branch July 28, 2021 06:44
bader pushed a commit to bader/llvm that referenced this pull request Jul 11, 2024
[pISA spec](https://curly-invention-299nr7q.pages.github.io/syntax.html)
expects all the statements to end with a semicolon:
**_"A statement in pISA can be an instruction or a declaration. All
statements end with a semicolon; except for labels:"_**.

The changes in this PR ensure that all the statements end with a
semicolon and pisa-as errors out in cases where this semicolon is
missing. The issue is also being tracked with this
JIRA:[IGC-9525](https://jira.devtools.intel.com/browse/IGC-9525).

Also added a new lit-test to provide coverage for this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants