Skip to content

[SYCL][Driver][NFC] Fix -help information for -Xs options #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2020
Merged

[SYCL][Driver][NFC] Fix -help information for -Xs options #1530

merged 1 commit into from
Apr 16, 2020

Conversation

mdtoguchi
Copy link
Contributor

Signed-off-by: Michael D Toguchi [email protected]

@mdtoguchi mdtoguchi requested a review from AGindinson as a code owner April 15, 2020 17:24
AGindinson
AGindinson approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a thought, would explicitly making these an alias to -Xsycl-target-backend retain the help information from the latter?

@AGindinson AGindinson changed the title [Driver][NFC] Fix -help information for -Xs options [SYCL][Driver][NFC] Fix -help information for -Xs options Apr 15, 2020
@mdtoguchi
Copy link
Contributor Author

Just as a thought, would explicitly making these an alias to -Xsycl-target-backend retain the help information from the latter?

The expected behaviors between -Xsycl-target-backend and -Xs are only aligned for the separate argument case. So maybe alias just for that variant. A different PR can be done for that.

@AGindinson
Copy link
Contributor

The expected behaviors between -Xsycl-target-backend and -Xs are only aligned for the separate argument case. So maybe alias just for that variant. A different PR can be done for that.

Fair enough, thanks.

@bader bader merged commit dfd98ae into intel:sycl Apr 16, 2020
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Apr 21, 2020
Merge remote-tracking branch 'origin/sycl' into private/abatashe/basi…
7a24da3 
…c_abi_checks

* origin/sycl:
  [SYCL][Driver] Enforce unique filenames when -save-temps is used (intel#1545)
  [SYCL] [xmethods] Allow replacing xmethod script (intel#1532)
  [SYCL] Add tests for inline asm feature (intel#1444)
  [SYCL][Doc] Add device_specific_kernel_queries extension. (intel#1540)
  [SYCL][USM] Remove unused header and unnecessary includes (intel#1537)
  Fix check-llvm dependencies (intel#1547)
  [SYCL] Add __SYCL_EXPORT to declaration of contextSetExtendedDeleter (intel#1531)
  [SYCL][Doc] Add static local memory query extension. (intel#1539)
  [SYCL][Doc] Add sycl_bitcast extension (intel#1541)
  [SYCL][NFC] Temporarily disable sporadically failing test (intel#1533)
  [SYCL][NFC] Adjust codeowners for sycl directory (intel#1529)
  [SYCL] Fix processing of spec consts referenced twice (intel#1524)
  [SYCL] Use correct macro name in export.hpp (intel#1527)
  [Driver][NFC] Fix -help information for -Xs options (intel#1530)
  [SYCL][Doc] Add Graph Scheduler design documentation (intel#1457)
  [SYCL] Add diagnostics for long double in device code (intel#1512)
  [SYCL] Add a mutex to state-modifying program functions (intel#1204)
  [SYCL][Test] Add Devicelib tests (intel#1256)
  [SYCL] Refactor semantic checks for variable types (intel#1513)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AGindinson AGindinson AGindinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdtoguchi @AGindinson @bader