Skip to content

[HIP] Don't run failing device global test on AMD #15327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

hdelan
Copy link
Contributor

@hdelan hdelan commented Sep 9, 2024

TODO: investigate why.

TODO: investigate why.
@hdelan hdelan requested a review from a team as a code owner September 9, 2024 09:19
@hdelan hdelan requested a review from againull September 9, 2024 09:19
@hdelan hdelan changed the title [HIP] Test failing on AMD [HIP] Don't run failing test on AMD Sep 9, 2024
@hdelan hdelan changed the title [HIP] Don't run failing test on AMD [HIP] Don't run failing device global test on AMD Sep 9, 2024
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hdelan
Copy link
Contributor Author

hdelan commented Sep 9, 2024

Ping @againull . This has broken post commit CI so would be good to merge.

@sarnex
Copy link
Contributor

sarnex commented Sep 9, 2024

Will merge now to unbreak HIP CI

@sarnex sarnex merged commit c49ef6b into intel:sycl Sep 9, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants