[SYCL] Do not crash if no matching store found #15658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lu, John <[email protected]>
sarnex
reviewed
Oct 10, 2024
| if (I!=std::end(Users)) { | ||
| auto *Store = cast<StoreInst>(*I); | ||
| MemoryAccess = Store->getValueOperand(); | ||
| } | ||
| } | ||
| return MemoryAccess->stripPointerCastsAndAliases(); |
There was a problem hiding this comment.
could we hit a similar problem here?
There was a problem hiding this comment.
I don't think it's possible to have a problem. A store must have a value. SpecConstants.cpp has similar code:
V = Store->getValueOperand()->stripPointerCasts();
Signed-off-by: Lu, John <[email protected]>
LU-JOHN
changed the title
sarnex
approved these changes
Oct 10, 2024
AlexeySachkov
approved these changes
Oct 11, 2024
Signed-off-by: Lu, John <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SYCLMutatePrintfAddrspacePass, when analyzing a format pointer to printf, do not crash when analyzing backwards through load/stores if no matching store is found.