[SYCL] Add missing supported AMDGPU architectures to SYCL #15723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeWeb
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
GeorgeWeb
force-pushed
the
georgi/update-sycl-supported-arch-docs
branch
from
5d7468d to
0d4bebb
Compare
GeorgeWeb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
approved these changes
Oct 16, 2024
mdtoguchi
approved these changes
Oct 16, 2024
gmlueck
approved these changes
Oct 16, 2024
GeorgeWeb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-reviewers-runtime gentle ping. Not a prio, just good to get in to support one of the new driver changes wrt allowed --offload-arch targets. Thanks! |
GeorgeWeb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
GeorgeWeb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
…supported-arch-docs
GeorgeWeb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
GeorgeWeb
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
ping @intel/llvm-reviewers-runtime @sergey-semenov Could we get a review on this, we're still missing one approval, and it's a fairly small change so it should be quick to review. |
|
@intel/llvm-gatekeepers this should be ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The three added
gfx7architectures were previously omitted from the list of supported ones for SYCL targeting AMDGPU.There is no rational for them to be excluded rather than a potential mistake when all the rest were added, so this PR adds them in.
All of these exactly match the LLVM AMDGPU support docs here: https://llvm.org/docs/AMDGPUUsage.html#processors.
This also makes reusing the current
OffloadArchenum in clang Driver easier with no concern of whether we have to filter these out for SYCL.