[UR] Bump UR with cfi sanitizer #16040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
force-pushed
the
ross/cfi
branch
from
f2f15aa to
39cb43d
Compare
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
force-pushed
the
ross/cfi
branch
from
39cb43d to
3243cba
Compare
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
force-pushed
the
ross/cfi
branch
from
3243cba to
4beeefd
Compare
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
force-pushed
the
ross/cfi
branch
from
4beeefd to
1a64ee8
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Pre-commit MR for: oneapi-src/unified-runtime#2222
RossBrunton
force-pushed
the
ross/cfi
branch
from
1a64ee8 to
1dcc534
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
callumfare
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
callumfare
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
callumfare
approved these changes
Nov 15, 2024
|
@intel/llvm-gatekeepers Please merge |
martygrant
pushed a commit
that referenced
this pull request
Dec 13, 2024
~~Update the UR tag to include oneapi-src/unified-runtime#2273 fixing `queue::fill` for the CUDA and HIP backends. It was previously producing incorrect outputs for any pattern size other than 1, 2, or a multiple of 4 bytes. A new optimisation is also added which speeds up the fill greatly if the pattern equals to the first word repeated throughout (e.g. all zeros). See the UR PR for more details.~~ _The UR tag update was collected in #16040 so now this PR only adds an e2e test as stated below._ Add a new e2e test to validate `queue::fill` outputs for any pattern size between 1 and 32 bytes. This test fails for CUDA and HIP before the UR change and passes with this PR. Other backends already worked correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-commit MR for: oneapi-src/unified-runtime#2222