[SYCL] Pass foffload-fp32-prec-[div/sqrt] options to device's BE #16107

MrSidims · 2024-11-18T13:21:07Z

No description provided.

clang/lib/Driver/ToolChains/SYCL.cpp

MrSidims · 2024-11-18T13:34:34Z

llvm/lib/SYCLLowerIR/SYCLSqrtFDivMaxErrorCleanUp.cpp

+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+// Remove llvm.fpbuiltin.[sqrt/fdiv] intrinsics to ensure compatibility with the


@gmlueck without the deep dive into the pass, may I ask you to check if the logic of the pass described in the comment makes sense to you? Note, I'm not adding annotation of the kernels with some optional kernel feature metadata, that could help discarding 'precise' options from the list of the BE options.

Reason is: currently we either have the intrinsics in the module or don't have them at all. And when we have the - non-precise option was already passed, so there is nothing to rewrite for BE options.

llvm/lib/SYCLLowerIR/SYCLSqrtFDivMaxErrorCleanUp.cpp

bader · 2024-11-25T17:33:59Z

This patch also adds a pass that removes llvm.fpbuiltin.[sqrt/fdiv] intrinsics
to ensure compatibility with the old drivers (that don't support SPV_INTEL_fp_max_error extension).

This sounds SPIR-V specific problem, so I think the right place to run the pass is SPIR-V generator (i.e. SPIR-V translator or SPIR-V backend).

MrSidims · 2025-02-03T11:10:27Z

This patch also adds a pass that removes llvm.fpbuiltin.[sqrt/fdiv] intrinsics
to ensure compatibility with the old drivers (that don't support SPV_INTEL_fp_max_error extension).

This sounds SPIR-V specific problem, so I think the right place to run the pass is SPIR-V generator (i.e. SPIR-V translator or SPIR-V backend).

On the other hand it's SYCL/OpenMP specific problem, how it would benefit https://github.com/KhronosGroup/SPIRV-LLVM-Translator community? Also it's still might be beneficial here for non-SPIR-V targets.

UPD: actually, I'm still leaning towards removing this pass. So let me try to land this patch without it and then restore it if needed.

@sqrt

This patch also adds a pass the removes llvm.fpbuiltin.[sqrt/fdiv] intrinsic functions from the module to ensure compatibility with the old drivers (that don't support SPV_INTEL_fp_max_error extension) in case if they are used with standart for OpenCL max-error (e.g [3.0/2.5] ULP) and there are no other llvm.fpbuiltin.* intrinsic functions, fdiv instructions or @sqrt builtins/intrinsics in the module. Signed-off-by: Sidorov, Dmitry <[email protected]>

Signed-off-by: Sidorov, Dmitry <[email protected]>

sycl/source/detail/program_manager/program_manager.cpp

Signed-off-by: Sidorov, Dmitry <[email protected]>

This reverts commit 9bef8ff.

Signed-off-by: Sidorov, Dmitry <[email protected]>

clang/test/Driver/sycl-foffload-fp32-prec-div.cpp

clang/test/Driver/sycl-foffload-fp32-prec-sqrt.cpp

Signed-off-by: Sidorov, Dmitry <[email protected]>

MrSidims · 2025-02-06T12:32:18Z

@steffenlarsen please have another look at the PR, thanks

steffenlarsen

LGTM!

MrSidims · 2025-02-06T13:51:42Z

@intel/llvm-gatekeepers please help with the merge

Since a pass that cleans up unnecessary llvm.fpbuiltin intrinsics was removed from #16107 we need to enable the extension by default to successfully translate them. Signed-off-by: Sidorov, Dmitry <[email protected]>

MrSidims had a problem deploying to WindowsCILock November 18, 2024 13:21 — with GitHub Actions Error

MrSidims commented Nov 18, 2024

View reviewed changes

clang/lib/Driver/ToolChains/SYCL.cpp Show resolved Hide resolved

MrSidims had a problem deploying to WindowsCILock November 18, 2024 13:29 — with GitHub Actions Error

MrSidims force-pushed the pass-sqrt-fdiv-opt-in-BE branch from b840a24 to 5490f22 Compare November 18, 2024 13:31

MrSidims had a problem deploying to WindowsCILock November 18, 2024 13:32 — with GitHub Actions Failure

MrSidims commented Nov 18, 2024

View reviewed changes

llvm/lib/SYCLLowerIR/SYCLSqrtFDivMaxErrorCleanUp.cpp Outdated Show resolved Hide resolved

MrSidims force-pushed the pass-sqrt-fdiv-opt-in-BE branch from 5490f22 to 8250855 Compare February 3, 2025 11:09

MrSidims had a problem deploying to WindowsCILock February 3, 2025 11:09 — with GitHub Actions Failure

MrSidims had a problem deploying to WindowsCILock February 3, 2025 12:31 — with GitHub Actions Failure

MrSidims had a problem deploying to WindowsCILock February 3, 2025 13:31 — with GitHub Actions Failure

MrSidims had a problem deploying to WindowsCILock February 5, 2025 13:14 — with GitHub Actions Failure

MrSidims had a problem deploying to WindowsCILock February 5, 2025 13:17 — with GitHub Actions Failure

MrSidims had a problem deploying to WindowsCILock February 5, 2025 14:02 — with GitHub Actions Failure

MrSidims marked this pull request as ready for review February 5, 2025 14:03

MrSidims requested review from a team as code owners February 5, 2025 14:03

MrSidims requested a review from steffenlarsen February 5, 2025 14:03

MrSidims added 6 commits February 5, 2025 06:15

fix comments

edaf76b

Signed-off-by: Sidorov, Dmitry <[email protected]>

format and tests

5452445

Signed-off-by: Sidorov, Dmitry <[email protected]>

remove the pass

c66c1d4

Signed-off-by: Sidorov, Dmitry <[email protected]>

add tests

b7044b5

Signed-off-by: Sidorov, Dmitry <[email protected]>

fix test

4cd8e0f

Signed-off-by: Sidorov, Dmitry <[email protected]>

steffenlarsen reviewed Feb 5, 2025

View reviewed changes

sycl/source/detail/program_manager/program_manager.cpp Outdated Show resolved Hide resolved

debug CI failures

9bef8ff

Signed-off-by: Sidorov, Dmitry <[email protected]>

MrSidims force-pushed the pass-sqrt-fdiv-opt-in-BE branch from e702fed to 9bef8ff Compare February 5, 2025 15:45

MrSidims had a problem deploying to WindowsCILock February 5, 2025 15:47 — with GitHub Actions Failure

Revert "debug CI failures"

f27ce15

This reverts commit 9bef8ff.

MrSidims had a problem deploying to WindowsCILock February 5, 2025 16:47 — with GitHub Actions Error

MrSidims had a problem deploying to WindowsCILock February 5, 2025 16:55 — with GitHub Actions Error

apply comment, fix test

3b240f9

Signed-off-by: Sidorov, Dmitry <[email protected]>

MrSidims force-pushed the pass-sqrt-fdiv-opt-in-BE branch from 182c991 to 3b240f9 Compare February 5, 2025 17:25

MrSidims had a problem deploying to WindowsCILock February 5, 2025 17:26 — with GitHub Actions Failure

MrSidims temporarily deployed to WindowsCILock February 5, 2025 18:13 — with GitHub Actions Inactive

MrSidims requested review from steffenlarsen and mdtoguchi February 5, 2025 18:35

mdtoguchi reviewed Feb 5, 2025

View reviewed changes

clang/test/Driver/sycl-foffload-fp32-prec-div.cpp Outdated Show resolved Hide resolved

mdtoguchi reviewed Feb 5, 2025

View reviewed changes

clang/test/Driver/sycl-foffload-fp32-prec-sqrt.cpp Outdated Show resolved Hide resolved

fix tests

abc2c20

Signed-off-by: Sidorov, Dmitry <[email protected]>

MrSidims temporarily deployed to WindowsCILock February 5, 2025 21:42 — with GitHub Actions Inactive

mdtoguchi approved these changes Feb 5, 2025

View reviewed changes

MrSidims temporarily deployed to WindowsCILock February 5, 2025 22:53 — with GitHub Actions Inactive

steffenlarsen approved these changes Feb 6, 2025

View reviewed changes

MrSidims requested a review from a team February 6, 2025 13:51

dm-vodopyanov merged commit 0106136 into intel:sycl Feb 6, 2025
15 checks passed

MrSidims mentioned this pull request Feb 10, 2025

[SYCL] Enable SPV_INTEL_fp_max_error by default #16942

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SYCL] Pass foffload-fp32-prec-[div/sqrt] options to device's BE #16107

[SYCL] Pass foffload-fp32-prec-[div/sqrt] options to device's BE #16107

MrSidims commented Nov 18, 2024 •

edited

Loading

MrSidims Nov 18, 2024 •

edited

Loading

MrSidims Nov 18, 2024

bader commented Nov 25, 2024

MrSidims commented Feb 3, 2025 •

edited

Loading

MrSidims commented Feb 6, 2025

steffenlarsen left a comment

MrSidims commented Feb 6, 2025

[SYCL] Pass foffload-fp32-prec-[div/sqrt] options to device's BE #16107

[SYCL] Pass foffload-fp32-prec-[div/sqrt] options to device's BE #16107

Conversation

MrSidims commented Nov 18, 2024 • edited Loading

MrSidims Nov 18, 2024 • edited Loading

Choose a reason for hiding this comment

MrSidims Nov 18, 2024

Choose a reason for hiding this comment

bader commented Nov 25, 2024

MrSidims commented Feb 3, 2025 • edited Loading

MrSidims commented Feb 6, 2025

steffenlarsen left a comment

Choose a reason for hiding this comment

MrSidims commented Feb 6, 2025

MrSidims commented Nov 18, 2024 •

edited

Loading

MrSidims Nov 18, 2024 •

edited

Loading

MrSidims commented Feb 3, 2025 •

edited

Loading