[XPTI] Follow rule of three in XPTI headers #16123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayylol
commented
Nov 19, 2024
| @@ -734,6 +741,8 @@ class uid_object_t { | |||
| MUId.instance = 0; | |||
| }; | |||
|
|
|||
| ~uid_object_t() = default; | |||
There was a problem hiding this comment.
Only has one data member to deal with (xpti::uid128_t MUId), so default destructor should be fine
ayylol
commented
Nov 19, 2024
Comment on lines
+1626
to
+1627
| tracepoint_t(const tracepoint_t &) = delete; | ||
| tracepoint_t &operator=(const tracepoint_t &) = delete; |
There was a problem hiding this comment.
if a tracepoint_t object with m_top set to true is copied we would call xptiSetUniversalId(xpti::invalid_uid) twice on both of their destructions, so we likely do not want to be able to copy.
|
@intel/llvm-reviewers-runtime @sergey-semenov Friendly ping |
sergey-semenov
approved these changes
Nov 21, 2024
|
Failed Tests (1): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.