Skip to content

[UR][L0] Add Support for External Semaphores #16162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

nrspruit
Copy link
Contributor

-pre-commit PR for oneapi-src/unified-runtime#2361

@JackAKirk
Copy link
Contributor

JackAKirk commented Dec 2, 2024

@GeorgeWeb
Copy link
Contributor

GeorgeWeb commented Dec 2, 2024

I assume the external semaphore related interop testing has been ran locally to ensure the feature implementation works correctly.
Ideally we'd like to see this PR to enable the testing on L0 devices by either adding level-zero to the relevant tests' REQUIRES line or via aspect support check, i.e., REQUIRES: aspect-ext_oneapi_bindless_images. Thanks!

@nrspruit
Copy link
Contributor Author

nrspruit commented Dec 2, 2024

Can you please test this feature via enabling l0 testing in

and/or any L0 specific testing as appropriate.

Thanks

Currently there is no driver that exists that supports this functionality so enabling the tests will have to wait until the L0 driver is released and installed in the CI that handles these features,

@nrspruit
Copy link
Contributor Author

nrspruit commented Dec 2, 2024

I assume the external semaphore related interop testing has been ran locally to ensure the feature implementation works correctly. Ideally we'd like to see this PR to enable the testing on L0 devices by either adding level-zero to the relevant tests' REQUIRES line or via aspect support check, i.e., REQUIRES: aspect-ext_oneapi_bindless_images. Thanks!

The tests can be enabled after we have an L0 driver released that supports this feature. Until then, this is enabling the UR L0 adapter to "enable" usage of the feature once an L0 driver with the support is available. When we have the driver which supports this feature in the CI, then I can post a patch to have this tested, otherwise this will fail.

@martygrant martygrant force-pushed the l0_external_semaphore branch from f74d1f9 to 166866a Compare December 5, 2024 09:31
@martygrant martygrant marked this pull request as ready for review December 5, 2024 10:40
@martygrant martygrant requested a review from a team as a code owner December 5, 2024 10:40
@martygrant martygrant merged commit 590960a into intel:sycl Dec 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants