[SYCL] Support print_graph with pre-C++11 ABI in non-preview mode
#16194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intel#15694 implemented the change under `-fpreview-breaking-changes` guard but we can do better than that.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
EwanC
reviewed
Nov 27, 2024
againull
reviewed
Nov 27, 2024
aelovikov-intel
commented
Nov 27, 2024
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
EwanC
approved these changes
Nov 28, 2024
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Dec 4, 2024
The former is defined by the toolchain while the latter is part of SDK, so using `_WIN32` is preferrable. The issue was exposed downstream due to recent changes from intel#16178 and intel#16194.
aelovikov-intel
added a commit
that referenced
this pull request
Dec 5, 2024
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Dec 16, 2024
I'm only able reproduce link error downstream for this API (and don't know what exactly is causing it), but the change is the same in nature as parts of intel#16178, intel#16194 and intel#16267
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Dec 16, 2024
…_breaking_changes` Follow-up for intel#16194. We must keep exporting it for backward ABI compatibility by default, but that isn't necessary for the next major release (which `-fpreview_breaking_changes` covers).
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Dec 16, 2024
…_breaking_changes` Follow-up for intel#16194. We must keep exporting it for backward ABI compatibility by default, but that isn't necessary for the next major release (which `-fpreview_breaking_changes` covers).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15694 implemented the change under
-fpreview-breaking-changesguard but we can do better than that.