[Driver][NFC] Update test to use internal sysroot for device libs #16350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no guarantee that the device libraries are going to be built for a given built compiler. Use the internal sysroot setting to allow for proper inclusion of dependent device libraries for SYCL testing.
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Can you elaborate this sentence? |
The test is checking for the libsycl-itt libraries to make sure they are being pulled in during the device link. These libraries aren't guaranteed to be built with the compiler so there is a possibility to run LIT testing against the compiler without these libraries being built, causing the test to fail. |
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
srividya-sundaram
approved these changes
Dec 12, 2024
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers, this looks ready for merge - thanks! |
KornevNikita
pushed a commit
that referenced
this pull request
Feb 19, 2025
…6350) There is no guarantee that the device libraries are going to be built for a given built compiler. Use the internal sysroot setting to allow for proper inclusion of dependent device libraries for SYCL testing.
KornevNikita
pushed a commit
that referenced
this pull request
Feb 25, 2025
…6350) There is no guarantee that the device libraries are going to be built for a given built compiler. Use the internal sysroot setting to allow for proper inclusion of dependent device libraries for SYCL testing.
KornevNikita
pushed a commit
that referenced
this pull request
Feb 25, 2025
…6350) There is no guarantee that the device libraries are going to be built for a given built compiler. Use the internal sysroot setting to allow for proper inclusion of dependent device libraries for SYCL testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no guarantee that the device libraries are going to be built for a given built compiler. Use the internal sysroot setting to allow for proper inclusion of dependent device libraries for SYCL testing.