[SYCL] Implement "swizzle" member function on swizzles #16353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It brings it closer to SYCL spec and makes more consistent by having "named" swizzle member functions (like `.hi()`/`.lo()`) and `.swizzle<...>()` behave in a similar way, i.e. we still have a bug when doing a swizzle on an expression tree. Note that the whole "expression tree" machinery is not standard-conformant and will be completely removed separately (under `-fpreview-breaking-changes` flag). I still want to implement this partial bugfix so that I could switch to a unified mixin-based implementation for swizzles on `vec`/`swizzle` classes, instead of doing preprocessor tricks with `swizzles.def` file.
|
First commit is in its own PR (#16352), so review can focus on the second one only. |
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Merged 'origin/sycl' after the test PR has been merged. This should be review-ready now. |
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It brings it closer to SYCL spec and makes more consistent by having "named"
swizzle member functions (like
.hi()/.lo()) and.swizzle<...>()behave ina similar way, i.e. we still have a bug when doing a swizzle on an expression
tree.
Note that the whole "expression tree" machinery is not standard-conformant and
will be completely removed separately (under
-fpreview-breaking-changesflag).I still want to implement this partial bugfix so that I could switch to a
unified mixin-based implementation for swizzles on
vec/swizzleclasses,instead of doing preprocessor tricks with
swizzles.deffile.