[SYCL] Unload libraries in jit_compiler and kernel_compiler_opencl destructors #16517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
changed the title
both objects are static so not sure if it is possible to track with UT |
uditagarwal97
approved these changes
Jan 3, 2025
jopperm
reviewed
Jan 6, 2025
sycl/source/detail/jit_compiler.hpp
Outdated
| @@ -98,6 +98,7 @@ class jit_compiler { | |||
| CompileSYCLFuncT CompileSYCLHandle = nullptr; | |||
| ResetConfigFuncT ResetConfigHandle = nullptr; | |||
| AddToConfigFuncT AddToConfigHandle = nullptr; | |||
| void *MLibraryHandle = nullptr; | |||
There was a problem hiding this comment.
Could this be a unique pointer as well, reusing the custom deleter from the newly-added unique pointer in jit_compiler's constructor? Then we wouldn't need to duplicate the unload logic in the destructor.
There was a problem hiding this comment.
Nit: The other members here don't carry the M prefix.
There was a problem hiding this comment.
done in c86ef55
There was a problem hiding this comment.
title is slightly updated too.
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
changed the title
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jopperm
reviewed
Jan 8, 2025
Signed-off-by: Tikhomirova, Kseniya <[email protected]>
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jopperm
approved these changes
Jan 8, 2025
|
@intel/llvm-gatekeepers hi, this PR is ready to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes memory leaks in jit_compiler and kernel_compiler_opencl classes.
Libraries loaded to provide compilation utils have to be released.