[SYCL] refactor and implement dynamic address space casts #16604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch provides an implementation for dynamic address space cast for NVPTX and AMDGPU. The patch also refactor the static cast by relying on a simple cast rather than the SPIR-V builtin. Signed-off-by: Victor Lomuller <[email protected]>
Naghasan
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Naghasan
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Naghasan
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Naghasan
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Naghasan
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
approved these changes
Jan 15, 2025
libclc/libspirv/lib/amdgcn-amdhsa/conversion/GenericCastToPtrExplicit.cl
Show resolved
Hide resolved
|
@intel/llvm-gatekeepers I believe this is ready to be merged |
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 26, 2025
This became possible sometime after one/all of * intel#15394 * intel#15543 * intel#16604
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch provides an implementation for
dynamic address space cast for NVPTX and AMDGPU.
The patch also refactor the static cast by relying on a simple cast rather than the SPIR-V builtin.