Skip to content

[CI] Update sycl-windows-run-tests.yml #16621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 14, 2025
Merged

[CI] Update sycl-windows-run-tests.yml #16621

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd7c3d7
[CI] Update sycl-windows-run-tests.yml
KornevNikita Jan 13, 2025
649afb6
add description
KornevNikita Jan 14, 2025
c33c3a2
use ref instead of build_ref
KornevNikita Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/sycl-rel-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,8 @@ jobs:
runner: '["Windows","gen12"]'
sycl_toolchain_archive: ${{ needs.build-win.outputs.artifact_archive_name }}
extra_lit_opts: --param gpu-intel-gen12=True
ref: sycl-rel-6_0_0
merge_ref: ''
build_ref: sycl-rel-6_0_0

cuda-aws-start:
needs: [ubuntu2204_build]
Expand Down
11 changes: 11 additions & 0 deletions .github/workflows/sycl-windows-run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,16 @@ on:
ref:
type: string
required: False
build_ref:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a description explaining the difference between build_ref and ref? thx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it better? 649afb6

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still unclear to me build_ref vs ref

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too:D it's not me who created this. Probably we can just use ref in both cases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, I don't know the original intent to have ref and build_ref, but may be it's to have a possibility to download the devops dir and the rest repo from different branches.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as far as i know theres only a single ref that checks out the source branch for tests to run, if its not too much work maybe we try combining the two

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed build_ref. Also converted to draft so I can test it without random merge.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, ping me again when youre ready for review/merge

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid even we'd do some digging/archeology on git history, the result would it just happened without well-defined purpose behind it. Reviewing all *ref and removing/unifying unnecessary sounds like the right path forward.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for merge

cool, ping me again when youre ready for review/merge

type: string
required: false
merge_ref:
description: |
Commit-ish to merge post-checkout if non-empty. Must be reachable from
the default_branch input paramter.
type: string
default: 'FETCH_HEAD'
required: False

sycl_toolchain_artifact:
type: string
Expand Down Expand Up @@ -69,6 +79,7 @@ jobs:
with:
path: llvm
ref: ${{ inputs.build_ref || github.sha }}
merge_ref: ${{ inputs.merge_ref }}
cache_path: "D:\\\\github\\\\_work\\\\repo_cache\\\\"
- name: Download compiler toolchain
uses: actions/download-artifact@v4
Expand Down
Loading