[SYCL][E2E] Add some compile-time "tracking" tests #16648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We run `test-e2e/PerformanceTests` in post-commit and that can be used for * tracking the compilation time on these tests over time * running them in pre-commit to measure expected improvements I also think that since PerformanceTests are "opt-in" in precommit, there is little sense in enforcing no `<sycl/sycl.hpp>` header in them.
aelovikov-intel
added
the
run-perf-tests
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jan 15, 2025
To be used in intel#16648.
steffenlarsen
approved these changes
Jan 16, 2025
I have some doubts about that. With how our headers interdependent, that would result in lots of regressions reported in multiple headers at once, not helping to narrow it down to the one causing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run
test-e2e/PerformanceTestsin post-commit and that can be used forI also think that since PerformanceTests are "opt-in" in precommit, there is little sense in enforcing no
<sycl/sycl.hpp>header in them.