Skip to content

[SYCL][UR][Bindless] Enable tests using Level Zero backend and their aspects #16862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Mar 4, 2025

Conversation

DBDuncan
Copy link
Contributor

@DBDuncan DBDuncan commented Jan 31, 2025

A number of working bindless images CI tests are disabled running on Level Zero backend. Enable them to improve test coverage. Enable corresponding feature aspects on the Level Zero backend.

A number of working bindless images CI tests are disabled running on Level Zero backend. Enable them to improve test coverage.
@DBDuncan DBDuncan requested a review from a team as a code owner January 31, 2025 16:41
@DBDuncan DBDuncan requested a review from a team as a code owner February 13, 2025 14:19
@DBDuncan
Copy link
Contributor Author

This PR has been updated to enable the corresponding test aspects on the L0 backend.

@DBDuncan
Copy link
Contributor Author

Corresponding UR PR: oneapi-src/unified-runtime#2705

@DBDuncan DBDuncan changed the title [SYCL][Bindless] Enable tests using Level Zero backend [SYCL][Bindless] Enable tests using Level Zero backend and their aspects Feb 13, 2025
@DBDuncan
Copy link
Contributor Author

MemorySanitizer/check_device_global.cpp is failing. Unrelated failure. Logged here: #16978

@DBDuncan
Copy link
Contributor Author

@przemektmalon Friendly ping for approval

Copy link
Contributor

@przemektmalon przemektmalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the small nit, LGTM.

@DBDuncan DBDuncan changed the title [SYCL][Bindless] Enable tests using Level Zero backend and their aspects [SYCL][UR][Bindless] Enable tests using Level Zero backend and their aspects Feb 20, 2025
@DBDuncan
Copy link
Contributor Author

@intel/unified-runtime-reviewers Friendly ping

@kbenzie
Copy link
Contributor

kbenzie commented Feb 20, 2025

This should be reviewed by L0 adapter maintainers but there's not currently a reviewer team specifically for that.

@kbenzie kbenzie requested a review from nrspruit February 20, 2025 11:54
@DBDuncan
Copy link
Contributor Author

This should be reviewed by L0 adapter maintainers but there's not currently a reviewer team specifically for that.

Ah got it. Will keep this in mind till the reviewer teams are sorted.

@DBDuncan
Copy link
Contributor Author

@nrspruit Friendly ping

@DBDuncan
Copy link
Contributor Author

@nrspruit Friendly ping for review please. kbenzie added you to this PR.

Copy link
Contributor

@nrspruit nrspruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DBDuncan
Copy link
Contributor Author

DBDuncan commented Mar 4, 2025

@intel/llvm-gatekeepers Should be good to merge.

@sarnex sarnex merged commit aa203ef into intel:sycl Mar 4, 2025
28 checks passed
jchlanda pushed a commit to jchlanda/llvm that referenced this pull request Mar 6, 2025
…aspects (intel#16862)

A number of working bindless images CI tests are disabled running on
Level Zero backend. Enable them to improve test coverage. Enable
corresponding feature aspects on the Level Zero backend.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants