-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL][UR][Bindless] Enable tests using Level Zero backend and their aspects #16862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A number of working bindless images CI tests are disabled running on Level Zero backend. Enable them to improve test coverage.
… in enabled tests
This PR has been updated to enable the corresponding test aspects on the L0 backend. |
Corresponding UR PR: oneapi-src/unified-runtime#2705 |
|
@przemektmalon Friendly ping for approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the small nit, LGTM.
@intel/unified-runtime-reviewers Friendly ping |
This should be reviewed by L0 adapter maintainers but there's not currently a reviewer team specifically for that. |
Ah got it. Will keep this in mind till the reviewer teams are sorted. |
@nrspruit Friendly ping |
@nrspruit Friendly ping for review please. kbenzie added you to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@intel/llvm-gatekeepers Should be good to merge. |
…aspects (intel#16862) A number of working bindless images CI tests are disabled running on Level Zero backend. Enable them to improve test coverage. Enable corresponding feature aspects on the Level Zero backend.
A number of working bindless images CI tests are disabled running on Level Zero backend. Enable them to improve test coverage. Enable corresponding feature aspects on the Level Zero backend.