[UR] Don't set -pie on shared objects #16880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbenzie
force-pushed
the
benie/ur-dont-set-pie-on-shared-objects
branch
from
1dcb35d to
ac46db5
Compare
kbenzie
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
force-pushed
the
benie/ur-dont-set-pie-on-shared-objects
branch
from
ac46db5 to
755928c
Compare
kbenzie
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
pbalcer
approved these changes
Feb 19, 2025
kbenzie
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Fixes intel#16677 by only setting `-pie` linker option in Release builds on executables rather than on any type of target.
kbenzie
force-pushed
the
benie/ur-dont-set-pie-on-shared-objects
branch
from
755928c to
eaa3639
Compare
kbenzie
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kbenzie
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16677 by only setting
-pielinker option in Release builds on executables rather than on any type of target.