Skip to content

[NFC][SYCL] Minor refactoring in sycl::vec #16934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

aelovikov-intel
Copy link
Contributor

@aelovikov-intel aelovikov-intel commented Feb 8, 2025

We're planning big refactoring under preview breaking changes mode to implement latest changes to the SYCL specification (not yet merged but already reviewed with Khronos). This is of several patches to split the changes into NFC refactoring and localized functional changes under preview guard.

@aelovikov-intel
Copy link
Contributor Author

Next change would be 63b9789, and the longer goal is something like sycl...aelovikov-intel:llvm:wip-vec

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but could you please add a description to the PR? The title doesn't explain the reason for the refactoring very well.

@aelovikov-intel aelovikov-intel merged commit 8b83ba8 into intel:sycl Feb 10, 2025
17 checks passed
@aelovikov-intel aelovikov-intel deleted the minor-vec-refactor branch February 10, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants