[NFCI][SYCL] Split vec's unary ops into individual mixins #16946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
We don't want constraints on non-template hidden friend operators to be implemented by templatizing it. It would be trivial with C++20 concepts, but we're limited to C++17. The proposed class hierarchy for `vecto_arith` helper had intended that, but implementation was only partial. We want to fix that while implementing the proposed specification changes to the vec/swizzle so setup infrastructure to do so now, to minimize the amount of "preview-breaking-changes" customizations later. The idea is to split each operator into an individual unrestrained mixin, so that the constraints could be implemented on top of it via `detail::ApplyIf` helper. This particular PR only implements such a change for unary operators. The rest will be implemented in a subsequent change to ease review process.
aelovikov-intel
force-pushed
the
vec-unary-mixins
branch
from
8531c7e to
9a9352c
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
is known: #16877 |
uditagarwal97
approved these changes
Feb 10, 2025
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 11, 2025
Refer to intel#16946 for the context.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 11, 2025
Refer to intel#16946 for the context.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 11, 2025
Refer to intel#16946 for the context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want constraints on non-template hidden friend operators to be implemented by templatizing it. It would be trivial with C++20 concepts, but we're limited to C++17. The proposed class hierarchy for
vecto_arithhelper had intended that, but implementation was only partial.We want to fix that while implementing the proposed specification changes to the vec/swizzle so setup infrastructure to do so now, to minimize the amount of "preview-breaking-changes" customizations later.
The idea is to split each operator into an individual unrestrained mixin, so that the constraints could be implemented on top of it via
detail::ApplyIfhelper. This particular PR only implements such a change for unary operators. The rest will be implemented in a subsequent change to ease review process.