-
Notifications
You must be signed in to change notification settings - Fork 768
[SYCL][E2E] Change test markup to enable build-only
mode on AMD
#17003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,9 @@ | |
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14387 | ||
// RUN: %{build} -o %t.out | ||
// RUN: %{run} %t.out | FileCheck %s | ||
// | ||
// UNSUPPORTED: target-amd | ||
// UNSUPPORTED-INTENDED: legacy image not supported on AMD | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why isnt this failing on amd today? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think what is going on is that the required feature never appears on any AMD devices, so historically it was an implicit |
||
|
||
#include <iostream> | ||
#include <sycl/accessor_image.hpp> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit surprising that it's a runtime condition for CUDA and compile-time for AMD. tagging @intel/llvm-reviewers-cuda for any potential follow-up to this.