[SYCL][E2E] Clean-up test-modes by removing workarounds
#17023
Conversation
| @@ -107,7 +107,7 @@ jobs: | |||
| image: ${{ matrix.image }} | |||
| image_options: ${{ matrix.image_options }} | |||
| target_devices: ${{ matrix.target_devices }} | |||
| extra_lit_opts: --param fallback-to-build-if-requires-build-and-run=True ${{ matrix.extra_lit_opts }} | |||
| extra_lit_opts: ${{ matrix.extra_lit_opts }} | |||
There was a problem hiding this comment.
is my understanding that the basic idea of this PR is to merge the build-and-test mode with the run mode, so we build all tests that can't be built in build mode in the run mode?
There was a problem hiding this comment.
Main motivation is to remove the build-and-run-mode feature, which was just introduced as a way to temporarily mark tests as not available for the split build/run mode while we figured out how to properly react to requires/unsupported statements.
The remaining tests that had this markup (which are all changed in this pr) had not yet had that requirement removed because they either never ran on CI and have regular build failures, or were AOT cpu tests and if we build these on a seperate machine we end up building for that machine's cpu architecture which if it is different than the run system's architecture it causes execution failures.
The fallback-to-build-if-requires-build-and-run option is also removed since that option only functions when a test has REQUIRES: build-and-run-mode
|
@intel/bindless-images-reviewers friendly ping |
|
@AllanZyne FYI, changed two more asan tests that added |
Got it. Thanks. |
|
@intel/llvm-gatekeepers this is ready to merge. |
|
There are post commit failures from merging this https://github.com/intel/llvm/actions/runs/13655785872 @ayylol |
|
I don't see any existing issues for these failing in post commit: |
The two ARC failures are present in the commit immediately prior to mine https://github.com/intel/llvm/actions/runs/13654810542/job/38173816553 ef28856 Let me take a closer look at these. |
That commit only touched different tests and docs so seems like it shouldn't have caused the regerssions. Did the containers get updated recently? |
|
They got updated in the commit after this here, depending on timing it's possible the container updating job there ran before the E2E test job for this commit or the previous one. If you believe the issue is the driver update please tell me, it's my problem then. |
Would you be able to look into this? I think the fact that this pr did not touch any of those tests, and neither did the previous pr points to that likely being the case. I also briefly tried running the |
|
Ok It was probably a timing issue with the container update, I'll take a look. |
|
#17306 for now |
- Removes the `build-and-run-mode` feature from e2e lit infrastructure,
as well as the remaining `REQUIRES: build-and-run-mode` markups found in
tests.
- Removes the `run-only` mode ignore line filtering workaround on
`REQUIRES: build-and-run-mode`.
- Adds `build-mode` to remove `test-mode-run-only` mode, this can be
tested for by checking `run-mode && !build-mode`.
- Marks CPU aot compilation lines with `%{run-aux}`, as those need to be
compiled on a system with the same CPU isa as the running system.
- Removes the `build-and-run-mode` feature from e2e lit infrastructure,
as well as the remaining `REQUIRES: build-and-run-mode` markups found in
tests.
- Removes the `run-only` mode ignore line filtering workaround on
`REQUIRES: build-and-run-mode`.
- Adds `build-mode` to remove `test-mode-run-only` mode, this can be
tested for by checking `run-mode && !build-mode`.
- Marks CPU aot compilation lines with `%{run-aux}`, as those need to be
compiled on a system with the same CPU isa as the running system.
build-and-run-modefeature from e2e lit infrastructure, as well as the remainingREQUIRES: build-and-run-modemarkups found in tests.run-onlymode ignore line filtering workaround onREQUIRES: build-and-run-mode.build-modeto removetest-mode-run-onlymode, this can be tested for by checkingrun-mode && !build-mode.%{run-aux}, as those need to be compiled on a system with the same CPU isa as the running system.