[UR] Replace loader handles with field at start of handle data #17118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
force-pushed
the
ross/new-nohandle
branch
2 times, most recently
from
9690a1c to
33d3736
Compare
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
RossBrunton
force-pushed
the
ross/new-nohandle
branch
from
33d3736 to
9cd3c85
Compare
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
RossBrunton
force-pushed
the
ross/new-nohandle
branch
from
9cd3c85 to
2dbed60
Compare
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
force-pushed
the
ross/new-nohandle
branch
from
2dbed60 to
8db8e63
Compare
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
force-pushed
the
ross/new-nohandle
branch
from
8db8e63 to
1990b3b
Compare
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
force-pushed
the
ross/new-nohandle
branch
from
1990b3b to
dd4e015
Compare
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
force-pushed
the
ross/new-nohandle
branch
2 times, most recently
from
407b51b to
9df489a
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
force-pushed
the
ross/new-nohandle
branch
from
9df489a to
dc4e033
Compare
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
force-pushed
the
ross/new-nohandle
branch
from
dc4e033 to
4f72152
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
force-pushed
the
ross/new-nohandle
branch
from
b9f1993 to
00bd9e2
Compare
|
@intel/dpcpp-nativecpu-reviewers please review, the native cpu changes are pretty minimal. |
uwedolinsky
approved these changes
May 12, 2025
kbenzie
force-pushed
the
ross/new-nohandle
branch
from
00bd9e2 to
dc23a0a
Compare
All handles from all backends are now required to implement `ddi_getter` and their first field must be a pointer to a `ur_ddi_table_t` (which also implies that they must not have a vtable). Instead of wrapping handles in a special wrapper type, we instead query the DDI table stored in the handle itself. This simplifies the loader greatly.
kbenzie
force-pushed
the
ross/new-nohandle
branch
from
dc23a0a to
5984920
Compare
EwanC
added a commit
to reble/llvm
that referenced
this pull request
May 14, 2025
The `ur_exp_command_buffer_handle_t_` definition in the CUDA adapter was missed in intel#17118 in the changes to inherit from a base handle. Discovered by seeing segfaults in the UR CTS tests locally, and git bisecting back to that change.
EwanC
added a commit
to reble/llvm
that referenced
this pull request
May 14, 2025
The `ur_exp_command_buffer_handle_t_` definition in the CUDA adapter was missed in intel#17118 in the changes to inherit from a base handle. Discovered by seeing segfaults in the UR CTS tests locally, and git bisecting back to that change.
kbenzie
pushed a commit
that referenced
this pull request
May 14, 2025
The `ur_exp_command_buffer_handle_t_` definition in the CUDA adapter was missed in #17118 in the changes to inherit from a base handle. Discovered by seeing segfaults in the UR CTS tests locally, and git bisecting back to that change.
github-actions bot
pushed a commit
to oneapi-src/unified-runtime
that referenced
this pull request
May 15, 2025
The `ur_exp_command_buffer_handle_t_` definition in the CUDA adapter was missed in intel/llvm#17118 in the changes to inherit from a base handle. Discovered by seeing segfaults in the UR CTS tests locally, and git bisecting back to that change.
aarongreig
pushed a commit
to oneapi-src/unified-runtime
that referenced
this pull request
May 15, 2025
The `ur_exp_command_buffer_handle_t_` definition in the CUDA adapter was missed in intel/llvm#17118 in the changes to inherit from a base handle. Discovered by seeing segfaults in the UR CTS tests locally, and git bisecting back to that change.
igchor
added a commit
to igchor/llvm
that referenced
this pull request
May 16, 2025
ur_queue_handle_t_ was not inheriting from ur::handle_base resulting in *reinterpret_cast<ur_dditable_t **>(hQueue) not working correctly. For some reason this worked on some platforms, and only manifested on PVC.
igchor
added a commit
to igchor/llvm
that referenced
this pull request
May 16, 2025
ur_queue_handle_t_ was not inheriting from ur::handle_base resulting in *reinterpret_cast<ur_dditable_t **>(hQueue) not working correctly. For some reason this worked on some platforms, and only manifested on PVC.
sarnex
pushed a commit
that referenced
this pull request
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated from oneapi-src/unified-runtime#2622
All handles from all backends are now required to implement
ddi_getterand their first field must be a pointer to aur_ddi_table_t(which also implies that they must not have a vtable).Instead of wrapping handles in a special wrapper type, we instead query the DDI table stored in the handle itself. This simplifies the loader greatly.