[SYCL] windows shutdown fix #17124
Closed
[SYCL] windows shutdown fix #17124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…design/GlobalObjectsInRuntime.md for a full technical description
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
requested review from
steffenlarsen,
sergey-semenov and
KseniyaTikhomirova
and removed request for
steffenlarsen
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
KseniyaTikhomirova
approved these changes
Mar 6, 2025
| if (GetModuleFileNameA(hModule, dllPath, MAX_PATH)) { | ||
| char exePath[MAX_PATH]; | ||
| if (GetModuleFileNameA(NULL, exePath, MAX_PATH)) { | ||
| if (std::string(dllPath) == std::string(exePath)) { |
There was a problem hiding this comment.
std::string constructor copies char arrays, strcmp would be better.
| // If loader is already closed, it'll return a not-initialized status | ||
| // which the UR should convert to SUCCESS code. But that isn't always | ||
| // working on Windows. This is a temporary workaround until that is fixed. | ||
| // TODO: Remove this workaround when UR is fixed, and restore |
There was a problem hiding this comment.
could we please create a JIRA task for this todo (blocked by UR issue)?
we have a lot of TODOs in code not tracked and forgotten.
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for various problems in Windows shutdown. See the sycl/doc/design/GlobalObjectsInRuntime.md for the technical discussion. This was broken out from #16618 to be its own pull request.