Skip to content

[SYCL] Refactor check_device_code/vector LIT tests #17153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

uditagarwal97
Copy link
Contributor

@uditagarwal97 uditagarwal97 commented Feb 25, 2025

This PR split check_device_code/vector LIT tests into two: one without preview-breaking-flag and one with the flag.
This would increase test coverage and also make it easier for us to switch tests during ABI-breaking window.

@uditagarwal97 uditagarwal97 self-assigned this Feb 25, 2025
@uditagarwal97 uditagarwal97 requested a review from a team as a code owner February 25, 2025 00:52
@uditagarwal97 uditagarwal97 changed the title [NFC] Refactor check_device_code/vector LIT tests [SYCL] Refactor check_device_code/vector LIT tests Feb 25, 2025
@uditagarwal97
Copy link
Contributor Author

uditagarwal97 commented Feb 25, 2025

@intel/llvm-gatekeepers the code formatter job is failing in undef deprecator because this PR added a test where LLVM IR uses undef. See llvm/llvm-project#118506

Running: git diff -U0 --pickaxe-regex -S '([^a-zA-Z0-9#_-]undef[^a-zA-Z0-9_-]|UndefValue::get)' 47630fea32e28d7b6f93f824876608b7f084737d aa16eb44e70b2cf82bbd2ed9f52fe8825b3d8420

sycl/test/check_device_code/vector/vector_as_preview.cpp
sycl/test/check_device_code/vector/vector_bf16_builtins_preview.cpp
sycl/test/check_device_code/vector/vector_convert_bfloat_preview.cpp
sycl/test/check_device_code/vector/vector_math_ops_preview.cpp
sycl/test/check_device_code/vector/vector_as.cpp
sycl/test/check_device_code/vector/vector_bf16_builtins.cpp
sycl/test/check_device_code/vector/vector_convert_bfloat.cpp
sycl/test/check_device_code/vector/vector_math_ops.cpp
error: undef deprecator failed

Do we have a BKM on how to handle such failures? Just ignore them or open a GH issue for front-end/middle-end team?

@aelovikov-intel
Copy link
Contributor

Do we have a BKM on how to handle such failures?

IMO, just merge.

@uditagarwal97
Copy link
Contributor Author

Failure in E2E test (HostInteropTask/interop-task-cuda-buffer-migrate.cpp) on CUDA in unrelated and reported here #17026
Skipping Windows E2E job - which failed earlier due to an infrastructure issue - as this PR only modifies Linux-only LIT tests.

@uditagarwal97 uditagarwal97 merged commit 3bd6b44 into intel:sycl Feb 25, 2025
17 of 20 checks passed
kurapov-peter pushed a commit to kurapov-peter/llvm that referenced this pull request Mar 5, 2025
This PR split `check_device_code/vector` LIT tests into two: one without
preview-breaking-flag and one with the flag.
This would increase test coverage and also make it easier for us to
switch tests during ABI-breaking window.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants