Skip to content

[SYCL][Driver] Link Native BF16 devicelib for lnl target #17154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 5, 2025

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Feb 25, 2025

Lunarlake platform supports native bf16 conversions, should link native bf16 devicelib.

@jinge90 jinge90 requested a review from a team as a code owner February 25, 2025 07:12
@jinge90 jinge90 requested a review from bashbaug February 25, 2025 07:12
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

Signed-off-by: jinge90 <[email protected]>
@jinge90
Copy link
Contributor Author

jinge90 commented Feb 26, 2025

Hi, @mdtoguchi
I fixed a bug in dg2 target name and added corresponding test, could you help review again?
Thanks very much.

Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates are fine - looks like you have a formatting issue after the typo fix.

@jinge90 jinge90 temporarily deployed to WindowsCILock March 4, 2025 08:56 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock March 4, 2025 09:36 — with GitHub Actions Inactive
@jinge90 jinge90 requested a review from a team March 5, 2025 01:28
@jinge90
Copy link
Contributor Author

jinge90 commented Mar 5, 2025

Hi, @intel/llvm-gatekeepers
Could you help merge this PR?
Thanks very much.

@uditagarwal97 uditagarwal97 merged commit a9295c1 into intel:sycl Mar 5, 2025
21 checks passed
jchlanda pushed a commit to jchlanda/llvm that referenced this pull request Mar 6, 2025
Lunarlake platform supports native bf16 conversions, should link native
bf16 devicelib.

---------

Signed-off-by: jinge90 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants