Skip to content

[DevTSAN] Support thread sanitizer for device offloading in TSAN pass #17181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 28, 2025
Merged

[DevTSAN] Support thread sanitizer for device offloading in TSAN pass #17181

merged 6 commits into from
Feb 28, 2025

Conversation

zhaomaosu
Copy link
Contributor

This PR is going to support thread sanitizer for device offloading (IR part)
1.defined a new class 'ThreadSanitizerOnSpirv' to do SPIR-V specific
instrumentation.
2.added an extra argument '__tsan_launch' to each spir kernels.
3.disable inserting module ctor for kernel code.
4.created a new global '__TsanKernelMetadata' to record spir kernels'
information.

@zhaomaosu
[DevTSAN] Support thread sanitizer for device offloading in TSAN pass
fc27c12 
This PR is going to support thread sanitizer for device offloading (IR part)
  1.defined a new class 'ThreadSanitizerOnSpirv' to do SPIR-V specific
    instrumentation.
  2.added an extra argument '__tsan_launch' to each spir kernels.
  3.disable inserting module ctor for kernel code.
  4.created a new global '__TsanKernelMetadata' to record spir kernels'
    information.
@zhaomaosu zhaomaosu marked this pull request as ready for review February 26, 2025 08:43
@zhaomaosu zhaomaosu requested review from a team as code owners February 26, 2025 08:43
@zhaomaosu zhaomaosu requested a review from a team February 26, 2025 08:43
uditagarwal97
uditagarwal97 approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to CODEOWNERS LGTM.

@zhaomaosu
Copy link
Contributor Author

Kindly ping @intel/dpcpp-tools-reviewers, could you please help review this PR? Thanks.

AlexeySachkov
AlexeySachkov approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it would be good to get feedback from @intel/dpcpp-sanitizers-review as well because they are intended reviewers for patches like this

@AlexeySachkov AlexeySachkov requested a review from a team February 27, 2025 12:23
@zhaomaosu
Copy link
Contributor Author

LGTM, but it would be good to get feedback from @intel/dpcpp-sanitizers-review as well because they are intended reviewers for patches like this

Thanks, Yingong already reviewed this PR on behalf @intel/dpcpp-sanitizers-review

@zhaomaosu zhaomaosu requested a review from a team February 28, 2025 12:16
@zhaomaosu
Copy link
Contributor Author

@intel/llvm-gatekeepers, this PR is ready to be merged. And the pre-ci failures are unrelated and tracked by issues:
#16877
#17026

@uditagarwal97 uditagarwal97 merged commit cd38f3f into intel:sycl Feb 28, 2025
19 of 21 checks passed
@zhaomaosu zhaomaosu deleted the support-dev-tsan-pass branch March 3, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllanZyne AllanZyne AllanZyne approved these changes

@AlexeySachkov AlexeySachkov AlexeySachkov approved these changes

@uditagarwal97 uditagarwal97 uditagarwal97 approved these changes

@yingcong-wu yingcong-wu yingcong-wu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhaomaosu @AllanZyne @AlexeySachkov @uditagarwal97 @yingcong-wu