[NFC][SYCL] Use bit_cast for bfloat16 casts. #17256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfloat16.hpp defines two help functions to cast between 16-bit integer and bfloat16 types. These fucntions duplicate logic of sycl::bit_cast standard function.
againull
approved these changes
Mar 1, 2025
|
Pre-commit failures analysis:
|
This was referenced Mar 3, 2025
joeatodd
added a commit
to codeplaysoftware/cutlass-sycl
that referenced
this pull request
Mar 3, 2025
`bfloat16toBits` was removed in [DPC++](intel/llvm#17256) to be replaced with `bit_cast`. Should fix CI failures described [here](#239 (comment)). --------- Co-authored-by: Tadej Ciglarič <[email protected]>
muhammad-tanvir-1211
pushed a commit
to muhammad-tanvir-1211/cutlass-fork
that referenced
this pull request
Mar 4, 2025
`bfloat16toBits` was removed in [DPC++](intel/llvm#17256) to be replaced with `bit_cast`. Should fix CI failures described [here](codeplaysoftware#239 (comment)). --------- Co-authored-by: Tadej Ciglarič <[email protected]>
taozha2
pushed a commit
to taozha2/cutlass-fork
that referenced
this pull request
Mar 6, 2025
`bfloat16toBits` was removed in [DPC++](intel/llvm#17256) to be replaced with `bit_cast`. Should fix CI failures described [here](codeplaysoftware#239 (comment)). --------- Co-authored-by: Tadej Ciglarič <[email protected]>
tdeng5
pushed a commit
to taozha2/cutlass-fork
that referenced
this pull request
Mar 6, 2025
`bfloat16toBits` was removed in [DPC++](intel/llvm#17256) to be replaced with `bit_cast`. Should fix CI failures described [here](codeplaysoftware#239 (comment)). --------- Co-authored-by: Tadej Ciglarič <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bfloat16.hpp defines two help functions to cast between 16-bit integer and bfloat16 types. These fucntions duplicate logic of sycl::bit_cast standard function.