Skip to content

[UR][SYCL] Add urUSMContextMemcpyExp API to enable device global support. #17268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 24 commits into
base: sycl
Choose a base branch
from
Open

[UR][SYCL] Add urUSMContextMemcpyExp API to enable device global support. #17268

wants to merge 24 commits into from

Conversation

aarongreig
Copy link
Contributor

@aarongreig aarongreig commented Mar 3, 2025 •
edited
Loading

Also adds a path using the new api to avoid a workaround introduced in #16565

@aarongreig aarongreig force-pushed the aaron/usmContextMemcpy branch from ed70b0c to cf7c09e Compare March 3, 2025 10:44
@aarongreig aarongreig force-pushed the aaron/usmContextMemcpy branch from 3f4ad4a to db41224 Compare March 5, 2025 16:42
@aarongreig aarongreig marked this pull request as ready for review March 7, 2025 12:27
@aarongreig aarongreig requested review from a team as code owners March 7, 2025 12:27
@aarongreig aarongreig requested a review from ldrumm March 7, 2025 12:27
Seanst98
Seanst98 approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@Seanst98 Seanst98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDA changes LGTM

kbenzie
kbenzie approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UR spec & test LGTM

pbalcer
pbalcer approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L0 lgtm.

jopperm
jopperm approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@jopperm jopperm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to ext_oneapi_get_device_global_address LGTM 🙏

@aarongreig
Copy link
Contributor Author

ping @intel/llvm-reviewers-runtime

@aarongreig
Copy link
Contributor Author

ping @intel/llvm-reviewers-runtime I think we'd like this change to make it into the release

@aarongreig aarongreig requested review from a team as code owners April 11, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jopperm jopperm jopperm approved these changes

@hvdijk hvdijk hvdijk approved these changes

@kbenzie kbenzie kbenzie approved these changes

@Seanst98 Seanst98 Seanst98 approved these changes

@igchor igchor igchor approved these changes

@sergey-semenov sergey-semenov sergey-semenov approved these changes

@ldrumm ldrumm Awaiting requested review from ldrumm ldrumm is a code owner automatically assigned from intel/llvm-reviewers-cuda

@pbalcer pbalcer Awaiting requested review from pbalcer

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@aarongreig @lukaszstolarczuk @jopperm @hvdijk @kbenzie @pbalcer @Seanst98 @igchor @sergey-semenov