Skip to content

[SYCL] Do not select device with a negative score #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

romanovvlad
Copy link
Contributor

According to the SYCL specification, if a device has a negative score
for a given selector it should not be selected.

@romanovvlad romanovvlad requested a review from againull May 25, 2020 15:53
@romanovvlad romanovvlad requested a review from a team as a code owner May 25, 2020 15:53
@romanovvlad romanovvlad requested a review from s-kanaev May 25, 2020 15:53
Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but some tests in cuda are failing.

@bader
Copy link
Contributor

bader commented May 27, 2020

@romanovvlad, could you resolve conflicts, please?

@romanovvlad romanovvlad marked this pull request as draft May 27, 2020 16:13
According to the SYCL specification, if a device has a negative score
for a given selector it should not be selected.
@romanovvlad romanovvlad force-pushed the private/vromanov/FixDefSel branch from c074a2a to aae572a Compare June 17, 2020 15:50
@romanovvlad romanovvlad marked this pull request as ready for review June 17, 2020 15:51
@romanovvlad romanovvlad requested a review from s-kanaev June 18, 2020 15:42
Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader merged commit 855d214 into intel:sycl Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants