[UR] added filename and line number to logs

[mateuszpn]

Added an option to print line number and filename in log file. When fileline:1 is specified in an environment variable describing log, e.g:

UR_LOG_LEVEL_ZERO="level:debug;flush:warning;fileline:1;output:file,juju-l0.log"

then every log entry will have source file and line added, like below:

ZE ---> zeInit(L0InitFlags) </home/user/llvm/unified-runtime/source/adapters/level_zero/common.cpp:141>

The significant changes are contained in the following files:

• ur_logger.hpp
• ur_logger_details.hpp
• ur_sinks.hpp
• CMakeList.txt

In the remaining files, the calls to the logger functions are replaced by macros (basically automatic change)

[hvdijk]

If the idea is that URLOG already includes the file name and line number, __FILE__ and __LINE__ should be removed here.

[mateuszpn]

Fixed

[hvdijk]

This doesn't quite look right now, if __FILE__ and __LINE__ are removed without also updating the format string to match, this cannot work, can it?

[lslusarczyk]

I think double FILE LINE is fine if one will set fileline:1, because

• default fileline is 0
• FILE from URLOG shortens path relatively to root, while FILE is a full path and one may want to 'grep' over each of them
• URLOG looks shorter in code and comply new standard of writing log statements

I would leave original code

    URLOG(ERR, "Not Implemented : {} - File : {} / Line : {}", __FUNCTION__,   \
          __FILE__, __LINE__);

@hvdijk ,
do we agree on that?

[hvdijk]

I disagree, File : {} / Line : {} was added to address a deficiency in the available logging, now that the standard logging will have it, there is no longer a need for it. If we want the ability to log full paths (I'm not sure that we do), we should implement that in URLOG, not work around it everywhere we use URLOG.

[lslusarczyk]

I see. OK. @mateuszpn , please just fix format string too (remove excesive {}).

[mateuszpn]

Yes, that's what I meant, it was my mistake to keep the braces. I am now running additional tests to find more problems like this.

[mateuszpn]

@ldrumm

Put the full paths in the logs without trimming?

Yes

Done, please re-review

[mateuszpn]

@intel/bindless-images-reviewers please review

[lslusarczyk]

@intel/llvm-gatekeepers , could you please merge this ? It seems this PR got finally last approvals needed.

[kbenzie]

This has caused post commit linux build and windows build failures. @mateuszpn is aware and working on a fix.