Skip to content

[SYCL] fix for cache tests interacting with multi tile devices #18126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2025
Merged

[SYCL] fix for cache tests interacting with multi tile devices #18126

merged 2 commits into from
Apr 22, 2025

Conversation

cperkinsintel
Copy link
Contributor

@cperkinsintel cperkinsintel commented Apr 22, 2025 •
edited
Loading

cache eviction might occur earlier than test expects on multi-tile systems. Solution is to use a context of just one device.

@cperkinsintel cperkinsintel marked this pull request as ready for review April 22, 2025 00:46
@cperkinsintel cperkinsintel requested a review from a team as a code owner April 22, 2025 00:46
@cperkinsintel cperkinsintel requested a review from againull April 22, 2025 00:46
uditagarwal97
uditagarwal97 approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Chris!

@cperkinsintel
Copy link
Contributor Author

cperkinsintel commented Apr 22, 2025 •
edited
Loading

This is a test only PR. The failures in syclcompat/memory/memory_management_test3_usmnone.cpp and InOrderEventsExt/get_last_event.cpp are perforce unrelated.

Issue: #17066

@uditagarwal97 uditagarwal97 merged commit c92b2d8 into intel:sycl Apr 22, 2025
36 of 38 checks passed
KornevNikita pushed a commit that referenced this pull request May 27, 2025
@cperkinsintel @KornevNikita
[SYCL] fix for cache tests interacting with multi tile devices (#18126)
5d9e997 
cache eviction might occur earlier than test expects on multi-tile
systems. Solution is to use a context of just one device.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uditagarwal97 uditagarwal97 uditagarwal97 approved these changes

@againull againull Awaiting requested review from againull againull is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cperkinsintel @uditagarwal97