Skip to content

[SYCL][E2E] Re-enable Windows BMG tests that are no longer slow/hanging #18286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2025

Conversation

ayylol
Copy link
Contributor

@ayylol ayylol commented May 1, 2025

Fixes #17255
Fixes #17916

These are no longer slow after updating the drivers

@ayylol ayylol temporarily deployed to WindowsCILock May 1, 2025 14:18 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock May 1, 2025 14:39 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock May 1, 2025 14:50 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock May 1, 2025 14:50 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock May 1, 2025 15:01 — with GitHub Actions Inactive
@ayylol ayylol marked this pull request as ready for review May 1, 2025 15:08
@ayylol ayylol requested review from a team as code owners May 1, 2025 15:08
@ayylol ayylol requested a review from againull May 1, 2025 15:08
@ayylol ayylol changed the title [SYCL][E2E] Re-enable slow windows bmg tests [SYCL][E2E] Re-enable Windows BMG tests that are no longer slow May 1, 2025
@ayylol
Copy link
Contributor Author

ayylol commented May 1, 2025

Windows BMG job took close to 4 minutes in https://github.com/intel/llvm/actions/runs/14776943337/attempts/1 and https://github.com/intel/llvm/actions/runs/14776943337/attempts/2 so looks like its no longer slow like in the issue.

@ayylol ayylol changed the title [SYCL][E2E] Re-enable Windows BMG tests that are no longer slow [SYCL][E2E] Re-enable Windows BMG tests that are no longer slow/hang May 1, 2025
@ayylol ayylol changed the title [SYCL][E2E] Re-enable Windows BMG tests that are no longer slow/hang [SYCL][E2E] Re-enable Windows BMG tests that are no longer slow/hanging May 1, 2025
@ayylol ayylol temporarily deployed to WindowsCILock May 1, 2025 16:08 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock May 1, 2025 16:29 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock May 1, 2025 16:41 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock May 1, 2025 16:41 — with GitHub Actions Inactive
@ayylol
Copy link
Contributor Author

ayylol commented May 2, 2025

@intel/unified-runtime-reviewers-level-zero friendly ping :)

@ayylol
Copy link
Contributor Author

ayylol commented May 5, 2025

@nrspruit @pbalcer @igchor @Xewar313 @mateuszpn @winstonzhang-intel Hello, could I get a quick review on this. Should be pretty straightforward since its just enabling tests that are working now, thanks.

@ayylol
Copy link
Contributor Author

ayylol commented May 6, 2025

@intel/llvm-gatekeepers this is ready to merge, thanks

@sarnex sarnex merged commit d96db8e into intel:sycl May 6, 2025
25 checks passed
@ayylol ayylol deleted the slow-tests branch May 6, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapters/level_zero_events_caching_leak.cpp hanging on Win BMG Tests slow on BMG Win
4 participants