Skip to content

[UR] Partially reapply "Move conformance tests over to lit" (#18382) #18392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

RossBrunton
Copy link
Contributor

This reverts commit 44ed9b7, but
excludes the problematic changes to jobs.

@RossBrunton RossBrunton requested review from a team as code owners May 9, 2025 14:33
@RossBrunton RossBrunton requested a review from reble May 9, 2025 14:33
@RossBrunton
Copy link
Contributor Author

Link to old MR: #17998

@RossBrunton RossBrunton marked this pull request as ready for review May 22, 2025 09:27
@RossBrunton
Copy link
Contributor Author

@intel/sycl-graphs-reviewers @intel/unified-runtime-reviewers Can I get this quickly looked at.

I've been investigating the CI failures (sorry for all the GitHub actions spam) but it looks like they are all caused by the random failures we've been having of late.

@kbenzie
Copy link
Contributor

kbenzie commented May 22, 2025

#18611 was just merged which should hopefully get the UR L0 v2 job green again.

Copy link
Contributor

@kbenzie kbenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than keeping long lines in CMake to a minimum, LGTM.

)

This reverts commit 44ed9b7, but
excludes the problematic changes to jobs.
@RossBrunton
Copy link
Contributor Author

@intel/sycl-graphs-reviewers All green now. Mind giving it a look?

@RossBrunton
Copy link
Contributor Author

@intel/llvm-gatekeepers Please merge.

@martygrant martygrant merged commit 3a37ab3 into intel:sycl May 23, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants