Skip to content

[UR][HIP][CUDA] Update UR CTS disabled tests #18396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025
Merged

[UR][HIP][CUDA] Update UR CTS disabled tests #18396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af87eda
[UR][HIP][CUDA] Update UR CTS disabled tests
npmiller May 9, 2025
398942e
Merge branch 'sycl' into ur-cts
npmiller May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions unified-runtime/source/adapters/hip/kernel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,8 @@ UR_APIEXPORT ur_result_t UR_APICALL urKernelSuggestMaxCooperativeGroupCountExp(
UR_APIEXPORT ur_result_t UR_APICALL urKernelSetArgValue(
ur_kernel_handle_t hKernel, uint32_t argIndex, size_t argSize,
const ur_kernel_arg_value_properties_t *, const void *pArgValue) {
UR_ASSERT(argSize, UR_RESULT_ERROR_INVALID_KERNEL_ARGUMENT_SIZE);

ur_result_t Result = UR_RESULT_SUCCESS;
try {
hKernel->setKernelArg(argIndex, argSize, pArgValue);
Expand Down
4 changes: 0 additions & 4 deletions unified-runtime/test/conformance/enqueue/urEnqueueKernelLaunch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,10 +633,6 @@ UUR_DEVICE_TEST_SUITE_WITH_PARAM(
uur::deviceTestWithParamPrinter<uur::BoolTestParam>);

TEST_P(urEnqueueKernelLaunchUSMLinkedList, Success) {
if (use_pool) {
UUR_KNOWN_FAILURE_ON(uur::HIP{});
}

ur_device_usm_access_capability_flags_t shared_usm_flags = 0;
ASSERT_SUCCESS(
uur::GetDeviceUSMSingleSharedSupport(device, shared_usm_flags));
Expand Down
7 changes: 0 additions & 7 deletions unified-runtime/test/conformance/enqueue/urEnqueueMemBufferCopyRect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,6 @@ UUR_DEVICE_TEST_SUITE_WITH_PARAM(

TEST_P(urEnqueueMemBufferCopyRectTestWithParam, Success) {
const auto name = getParam().name;
if (name.find("copy_row_2D") != std::string::npos) {
UUR_KNOWN_FAILURE_ON(uur::HIP{});
}

if (name.find("copy_3D_2D") != std::string::npos) {
UUR_KNOWN_FAILURE_ON(uur::HIP{});
}

UUR_KNOWN_FAILURE_ON(uur::LevelZero{}, uur::LevelZeroV2{});

Expand Down
9 changes: 0 additions & 9 deletions unified-runtime/test/conformance/enqueue/urEnqueueMemBufferWriteRect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,6 @@ UUR_DEVICE_TEST_SUITE_WITH_PARAM(
uur::printRectTestString<urEnqueueMemBufferWriteRectTestWithParam>);

TEST_P(urEnqueueMemBufferWriteRectTestWithParam, Success) {
const auto name = getParam().name;
if (name.find("write_row_2D") != std::string::npos) {
UUR_KNOWN_FAILURE_ON(uur::HIP{});
}

if (name.find("write_3D_2D") != std::string::npos) {
UUR_KNOWN_FAILURE_ON(uur::HIP{});
}

UUR_KNOWN_FAILURE_ON(uur::LevelZero{}, uur::LevelZeroV2{});

// Unpack the parameters.
Expand Down
13 changes: 0 additions & 13 deletions unified-runtime/test/conformance/exp_command_buffer/rect_write.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,19 +117,6 @@ UUR_DEVICE_TEST_SUITE_WITH_PARAM(
urCommandBufferAppendMemBufferWriteRectTestWithParam>);

TEST_P(urCommandBufferAppendMemBufferWriteRectTestWithParam, Success) {
const auto name = getParam().name;

// This file is based on enqueue/urEnqueueMemBufferWriteRect.cpp
// because of this, these checks are present here,
// since there were present in original code
if (name.find("write_row_2D") != std::string::npos) {
UUR_KNOWN_FAILURE_ON(uur::HIP{});
}

if (name.find("write_3D_2D") != std::string::npos) {
UUR_KNOWN_FAILURE_ON(uur::HIP{});
}

UUR_KNOWN_FAILURE_ON(uur::LevelZero{});

// Zero it to begin with since the write may not cover the whole buffer.
Expand Down
4 changes: 1 addition & 3 deletions unified-runtime/test/conformance/kernel/urKernelGetInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,6 @@ TEST_P(urKernelGetInfoTest, SuccessAttributes) {
}

TEST_P(urKernelGetInfoTest, SuccessNumRegs) {
UUR_KNOWN_FAILURE_ON(uur::HIP{});

const ur_kernel_info_t property_name = UR_KERNEL_INFO_NUM_REGS;
size_t property_size = 0;

Expand All @@ -217,7 +215,7 @@ TEST_P(urKernelGetInfoTest, SuccessNumRegs) {
}

TEST_P(urKernelGetInfoTest, SuccessSpillMemSize) {
UUR_KNOWN_FAILURE_ON(uur::HIP{}, uur::OpenCL{});
UUR_KNOWN_FAILURE_ON(uur::OpenCL{});

ur_kernel_info_t property_name = UR_KERNEL_INFO_SPILL_MEM_SIZE;
size_t property_size = 0;
Expand Down
2 changes: 1 addition & 1 deletion unified-runtime/test/conformance/kernel/urKernelSetArgValue.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ TEST_P(urKernelSetArgValueTest, InvalidKernelArgumentIndex) {
}

TEST_P(urKernelSetArgValueTest, InvalidKernelArgumentSize) {
UUR_KNOWN_FAILURE_ON(uur::HIP{}, uur::OpenCL{"Intel(R) UHD Graphics 770"});
UUR_KNOWN_FAILURE_ON(uur::OpenCL{"Intel(R) UHD Graphics 770"});

ASSERT_EQ_RESULT(UR_RESULT_ERROR_INVALID_KERNEL_ARGUMENT_SIZE,
urKernelSetArgValue(kernel, 2, 0, nullptr, &arg_value));
Expand Down
8 changes: 0 additions & 8 deletions unified-runtime/test/conformance/memory/urMemImageCreate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ UUR_DEVICE_TEST_SUITE_WITH_PARAM(
TEST_P(urMemImageCreateTestWith1DMemoryTypeParam, Success) {
UUR_KNOWN_FAILURE_ON(uur::OpenCL{"Intel(R) FPGA"});

if (getParam() == UR_MEM_TYPE_IMAGE1D_ARRAY) {
UUR_KNOWN_FAILURE_ON(uur::CUDA{});
}

ur_image_desc_t image_desc_with_param{
UR_STRUCTURE_TYPE_IMAGE_DESC, ///< [in] type of this structure
nullptr, ///< [in][optional] pointer to extension-specific structure
Expand Down Expand Up @@ -128,10 +124,6 @@ UUR_DEVICE_TEST_SUITE_WITH_PARAM(
TEST_P(urMemImageCreateTestWith2DMemoryTypeParam, Success) {
UUR_KNOWN_FAILURE_ON(uur::OpenCL{"Intel(R) FPGA"});

if (getParam() == UR_MEM_TYPE_IMAGE2D_ARRAY) {
UUR_KNOWN_FAILURE_ON(uur::CUDA{});
}

ur_image_desc_t image_desc_with_param{
UR_STRUCTURE_TYPE_IMAGE_DESC, ///< [in] type of this structure
nullptr, ///< [in][optional] pointer to extension-specific structure
Expand Down
2 changes: 0 additions & 2 deletions unified-runtime/test/conformance/program/urProgramGetInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,6 @@ TEST_P(urProgramGetInfoTest, SuccessBinaries) {
}

TEST_P(urProgramGetInfoTest, SuccessNumKernels) {
UUR_KNOWN_FAILURE_ON(uur::HIP{});

size_t property_size = 0;
const ur_program_info_t property_name = UR_PROGRAM_INFO_NUM_KERNELS;

Expand Down
Loading