[UR] Check for memory alignment before calling clEnqueueMemFillINTEL_fn in OpenCL #18423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Arc fails tracked here #18416 |
Those are not the same tests. |
|
Created an issue for them here #18463 |
aelovikov-intel
approved these changes
May 14, 2025
npmiller
approved these changes
May 15, 2025
kbenzie
reviewed
May 21, 2025
martygrant
added a commit
that referenced
this pull request
May 21, 2025
…eueCommandForCG (#18517) Add UR error code when throwing exception from Scheduler::enqueueCommandForCG. Remove message string from non adapter specific error exception in checkUrResult as it's only used in the adapter specific error path. This is related to oneapi-src/unified-runtime#2440 and #18423 where `clEnqueueMemFillINTEL` was failing with -30 (`CL_INVALID_VALUE`) but no detail was provided in the log: ``` terminate called after throwing an instance of 'sycl::_V1::exception' what(): Enqueue process failed. Aborted (core dumped) ``` This is because the first exception thrown from `checkUrResult` was being hidden by a second exception thrown from `Scheduler::enqueueCommandForCG`. I've modified this second exception to include the UR result. The output now looks like: ``` terminate called after throwing an instance of 'sycl::_V1::exception' what(): Enqueue process failed. Native API failed. Native API returns: 4 (UR_RESULT_ERROR_INVALID_VALUE) ```
rafbiels
approved these changes
May 21, 2025
martygrant
force-pushed
the
martin/checkAlignmentUSMFill
branch
from
eb282a1 to
8aab8c8
Compare
bashbaug
reviewed
May 21, 2025
bashbaug
approved these changes
May 21, 2025
kbenzie
approved these changes
May 21, 2025
|
@bashbaug I've opened an issue to look at the L0 adapter |
martygrant
force-pushed
the
martin/checkAlignmentUSMFill
branch
from
edba358 to
5ef4a39
Compare
martygrant
force-pushed
the
martin/checkAlignmentUSMFill
branch
from
5ef4a39 to
204a2ec
Compare
martygrant
force-pushed
the
martin/checkAlignmentUSMFill
branch
from
204a2ec to
2d7d393
Compare
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
… OpenCL. Use checkUSMImplAlignment from the Hip adapter for this but moved it to a common header.
…ke single *pointer and deference at calls sites where double** was being passed.
martygrant
force-pushed
the
martin/checkAlignmentUSMFill
branch
from
2d7d393 to
4aa4f89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes oneapi-src/unified-runtime#2440
clEnqueueMemFillINTEL returns CL_INVALID_VALUE if dst_ptr is NULL, or if dst_ptr is not aligned to pattern_size bytes.
This PR adds a memory alignment check before calling
clEnqueueMemFillINTELto ensure we can safely call it, otherwise take the host side copy path.Re-enables the
USM/fill_any_size.cppand also movescheckUSMImplAlignmentfrom Hip into a common header so it can be used in both Hip and OpenCL.