Skip to content

[SYCL][ESIMD] Explicit SIMD math APIs. #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 7, 2020
Merged

[SYCL][ESIMD] Explicit SIMD math APIs. #1855

merged 5 commits into from
Jul 7, 2020

Conversation

DenisBakhvalov
Copy link
Contributor 

This commit adds implementation of Explicit SIMD
math APIs along with math intrinsics used
to implement operations with SIMD classes.

Author:         Chen, Gang Y <[email protected]>
Co-authored-by: Chen, Kai Yu <[email protected]>

Signed-off-by: Denis Bakhvalov <[email protected]>

@DenisBakhvalov DenisBakhvalov requested a review from a team as a code owner June 10, 2020 02:46
@DenisBakhvalov DenisBakhvalov requested a review from rbegam June 10, 2020 02:46
@DenisBakhvalov
Copy link
Contributor Author

Review only 3rd commit:
[SYCL][ESIMD] Explicit SIMD math APIs.

@DenisBakhvalov DenisBakhvalov force-pushed the private/dbakhval-esimd-math branch from f541b48 to 365aa8a Compare June 10, 2020 03:06
@DenisBakhvalov DenisBakhvalov added the esimd Explicit SIMD feature label Jun 11, 2020
Pennycook
Pennycook requested changes Jun 11, 2020
View reviewed changes
rbegam
rbegam reviewed Jun 11, 2020
View reviewed changes
rbegam
rbegam reviewed Jun 11, 2020
View reviewed changes
@kbobrovs kbobrovs mentioned this pull request Jun 12, 2020
Merged
@cmc-rep cmc-rep force-pushed the private/dbakhval-esimd-math branch from 368c108 to 05cb7a8 Compare June 22, 2020 21:25
keryell
keryell reviewed Jun 23, 2020
View reviewed changes
Copy link
Contributor

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite clearer!

@cmc-rep cmc-rep force-pushed the private/dbakhval-esimd-math branch 2 times, most recently from a1bf39f to de85d38 Compare June 23, 2020 23:29
Pennycook
Pennycook previously approved these changes Jun 24, 2020
View reviewed changes
DenisBakhvalov and others added 2 commits July 2, 2020 11:25
@DenisBakhvalov @kychendev @kbobrovs
[SYCL][ESIMD] Add basic headers for ESIMD runtime library.
18504a1 
This patch adds basic headers used to implement
Explicit SIMD APIs and integrates them into deployment.

Signed-off-by: Denis Bakhvalov <[email protected]>
Author:         Wei Pan
Co-authored-by: Chen, Kai Yu <[email protected]>
Co-authored-by: Chen, Gang Y <[email protected]>
Co-authored-by: Bobrovsky, Konstantin S <[email protected]>
Signed-off-by: Denis Bakhvalov <[email protected]>
@DenisBakhvalov
[SYCL][ESIMD] Add simd and simd_view classes
c8f9e0e 
This patch adds simd and simd_view class implementation
used to implement Explicit SIMD vector APIs.

Author:         Wei Pan
Co-authored-by: Chen, Gang Y <[email protected]>
Co-authored-by: Bobrovsky, Konstantin S <[email protected]>
Co-authored-by: Ashar, Pratik J <[email protected]>

Signed-off-by: Denis Bakhvalov <[email protected]>
@DenisBakhvalov DenisBakhvalov force-pushed the private/dbakhval-esimd-math branch from de85d38 to 017a461 Compare July 2, 2020 19:18
@DenisBakhvalov
[SYCL][ESIMD] Explicit SIMD math APIs.
0519707 
This commit adds implementation of Explicit SIMD
math APIs along with math intrinsics used
to implement operations with SIMD classes.

Author:         Chen, Gang Y <[email protected]>
Co-authored-by: Chen, Kai Yu <[email protected]>

Signed-off-by: Denis Bakhvalov <[email protected]>
@DenisBakhvalov DenisBakhvalov force-pushed the private/dbakhval-esimd-math branch from 017a461 to 0519707 Compare July 2, 2020 19:19
@bader bader requested a review from rbegam July 3, 2020 18:36
@bader
Copy link
Contributor

bader commented Jul 3, 2020

@DenisBakhvalov, please, resolve merge conflicts.

rbegam
rbegam approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@rbegam rbegam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader merged commit 14af095 into intel:sycl Jul 7, 2020
FreddyLeaf pushed a commit to FreddyLeaf/llvm that referenced this pull request Mar 22, 2023
@MrSidims @FreddyLeaf
Add an option for NonSemantic.Shader.DebugInfo.100 (intel#1855)
30f5b3b 
Under this option this extended instruction set will be implemented
Spec:
https://github.com/KhronosGroup/SPIRV-Registry/blob/main/nonsemantic/NonSemantic.Shader.DebugInfo.100.asciidoc

TODO: to rename NonSemantic.Kernel.DebugInfo.100 to
NonSemantic.Shader.DebugInfo.200 when the name is stable

Signed-off-by: Sidorov, Dmitry <[email protected]>

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@a8c3ba2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader left review comments

@keryell keryell keryell left review comments

@cmc-rep cmc-rep cmc-rep left review comments

@rbegam rbegam rbegam approved these changes

@Pennycook Pennycook Pennycook left review comments

@rolandschulz rolandschulz Awaiting requested review from rolandschulz

@kbobrovs kbobrovs Awaiting requested review from kbobrovs

@kychendev kychendev Awaiting requested review from kychendev

Assignees
No one assigned
Labels
esimd Explicit SIMD feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DenisBakhvalov @bader @Pennycook @keryell @cmc-rep @rbegam