Rename piclProgramCreateWithBinary to piProgramCreateWithBinary #1865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernknafla
requested review from
kbobrovs,
smaslov-intel and
a team
as code owners
smaslov-intel
previously approved these changes
Jun 10, 2020
kbobrovs
previously approved these changes
Jun 10, 2020
|
The |
|
@kbobrovs I split the commit into two parts, one for the renaming and one for the |
|
Seeing that #1791 got merged. Will rebase this soon. |
As all PI backends (OpenCL, Level Zero, CUDA) implement the `piclProgramCreateWithBinary` function we rename it to `piProgramCreateWithBinary` as it isn't OpenCL-specifici anymore. Signed-off-by: Bjoern Knafla <[email protected]>
Signed-off-by: Bjoern Knafla <[email protected]>
bjoernknafla
dismissed stale reviews from kbobrovs and smaslov-intel
via
1f649f9
bjoernknafla
force-pushed
the
bjoern/rename-piclprogramcreatewithbinary-to-piprogramcreatewithbinary
branch
from
6b33771 to
1f649f9
Compare
|
Rebased after #1791 got merged. |
bader
approved these changes
Jun 11, 2020
|
Worried that |
Don't worry. Our internal testing is overloaded, but I don't see any issues and just a few checks are left. |
bjoernknafla
deleted the
bjoern/rename-piclprogramcreatewithbinary-to-piprogramcreatewithbinary
branch
bb-sycl
pushed a commit
that referenced
this pull request
Apr 4, 2023
This change fixes the following issues: Unchecked return value Explicit NULL dereferenced Thanks Signed-off-by: Arvind Sudarsanam <[email protected]> Original commit: KhronosGroup/SPIRV-LLVM-Translator@4355f70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As all PI backends (OpenCL, Level Zero, CUDA) implement the
piclProgramCreateWithBinaryfunction we rename it topiProgramCreateWithBinaryas it isn't OpenCL-specifici anymore.The first commit applies the naming change.
The second commit applies clang-format and has many changes in
pi_cuda.cpp.For the changed LIT test to pass the following PR (with an interactive rebase) is required first: #1791