[SYCL][CUDA] Enable cl_khr_3d_image_writes OpenCL extension for NVPTX targets #1977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalloc
requested review from
elizabethandrews,
Fznamznon and
premanandrao
as code owners
nyalloc
changed the title
Fznamznon
reviewed
Jun 25, 2020
nyalloc
changed the title
nyalloc
changed the title
nyalloc
force-pushed
the
stuart/cl_khr_3d_image_writes
branch
from
4384f7f to
6153c79
Compare
Fznamznon
previously approved these changes
Jun 29, 2020
Fznamznon
previously approved these changes
Jun 30, 2020
bader
reviewed
Jun 30, 2020
|
@StuartDAdams, please, resolve merge conflicts as well. |
A bunch of these PRs now have merge conflicts as the SYCL branch has been updated. I'll work through each of them and rebase / fix any conflicts ASAP. |
Removed expected warning for cl_khr_3d_image_writes
nyalloc
force-pushed
the
stuart/cl_khr_3d_image_writes
branch
from
4d1a846 to
a1f11cc
Compare
bader
previously approved these changes
Jul 7, 2020
Fznamznon
previously approved these changes
Jul 7, 2020
|
@StuartDAdams, one test is failing:
|
bader
previously approved these changes
Jul 9, 2020
|
Still failing |
Co-authored-by: Steffen Larsen <[email protected]>
bader
approved these changes
Jul 10, 2020
This was referenced Jul 15, 2020
jsji
pushed a commit
that referenced
this pull request
May 26, 2023
…ion (#1977) LLVM compileUnit dwoId is translated to/from DebugBuildIdentifier. LLVM compileUnit splitDebugFilename is translated to/from DebugStoragePath. Specification: https://github.com/KhronosGroup/SPIRV-Registry/blob/main/nonsemantic/NonSemantic.Shader.DebugInfo.100.asciidoc#DebugBuildIdentifier https://github.com/KhronosGroup/SPIRV-Registry/blob/main/nonsemantic/NonSemantic.Shader.DebugInfo.100.asciidoc#DebugStoragePath Original commit: KhronosGroup/SPIRV-LLVM-Translator@7ebb389
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable cl_khr_3d_image_writes so that builtin for that image type can be implemented properly.
Note: due the issue #1814, we can't enable this extension for the sycldevice context. This would blindly enable C++ and SYCL modes, making is unusable in libclc. This will be fixed once the issue is resolved.