[SYCL][CUDA][WIP] Lower OpenCL image type to CUDA image descriptors #1978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalloc
requested review from
elizabethandrews,
Fznamznon and
premanandrao
as code owners
nyalloc
changed the title
nyalloc
changed the title
nyalloc
changed the title
Ah... I didn't get this part. Separate PRs make sense to me now. :-) |
nyalloc
changed the title
Implemented sampled_image_cuda.cl
nyalloc
force-pushed
the
stuart/CGOpenCLRuntime
branch
from
24d862a to
5258552
Compare
premanandrao
reviewed
Jul 4, 2020
bader
approved these changes
Jul 6, 2020
Fznamznon
approved these changes
Jul 6, 2020
againull
pushed a commit
to againull/llvm
that referenced
this pull request
May 4, 2023
In NonSemantic.Shader.DebugInfo.200 DebugLexicalBlock has Inline namespace parameter, which specifies if C/C++ namespace is inline or not. It allows us to save `exportSymbols` field of `DINamespace` metadata. Spec: KhronosGroup/SPIRV-Registry#186 Original commit: KhronosGroup/SPIRV-LLVM-Translator@9729086
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands upon functionality introduced in #1945 and provides testing. Should be merged after #1945.
In CUDA images are descriptors represented as an 64 bits integer. The PR lowers the OpenCL image type to this descriptor so it can be processed properly by the NVPTX backend and allow image builtins implementation for this target.
Independent image/sampler are not supported by CUDA, they will be emulated in the libclc. To allow this emulation we need to lower the sampler type to i32. The sampled image type (return type of __spirv_SampledImage) is lowered into a struct containing the image descriptor (i64) and the sampler (i32).