Skip to content

[SYCL][CUDA] Add support for ALLOC_HOST_PTR #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

Ruyk
Copy link
Contributor

@Ruyk Ruyk commented Jun 26, 2020

Allocates pinned-memory when ALLOC_HOST_PTR flag is passed to piMemBufferCreate.
This is still not used in SYCL RT yet.

Signed-off-by: Ruyman Reyes [email protected]

@Ruyk Ruyk requested review from smaslov-intel and a team as code owners June 26, 2020 20:37
@bader bader added the cuda CUDA back-end label Jun 29, 2020
@bader
Copy link
Contributor

bader commented Jul 3, 2020

@intel/llvm-reviewers-cuda, @smaslov-intel, @intel/llvm-reviewers-runtime, ping.

Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I believe @smaslov-intel should approve also.

@smaslov-intel
Copy link
Contributor

This is still not used in SYCL RT yet.

Why then adding this at all? Are there plans to use it? For what?

Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader bader merged commit aee2d6c into intel:sycl Jul 6, 2020
nyalloc added a commit to nyalloc/llvm that referenced this pull request Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda CUDA back-end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants