[SYCL] Do not emit const static data members that are not const-… #2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alized Const static data members need to be either zero-initialized or constant-initialized. We were emitting all const static data members before, which needed address space casts from constant-space to private-space. This change also reverts the address-space cast introduced in intel#1774 Signed-off-by: Premanand M Rao <[email protected]>
premanandrao
force-pushed
the
remote_static_init
branch
from
e1f62c3 to
d9660d0
Compare
Fznamznon
reviewed
Jul 2, 2020
Const static data members need to be either zero-initialized or constant-initialized. We were emitting initializers for all const static data members before, which needed invalid address space casts from constant-space to private-space. This change also reverts the address-space cast introduced in intel#1774 Signed-off-by: Premanand M Rao <[email protected]>
Fznamznon
reviewed
Jul 3, 2020
Const static variables need to be either zero-initialized or constant-initialized. We were emitting initializers for all const static variables before, which needed invalid address space casts from constant-space to private-space. We now diagnose when they are neither zero- nor constant-initialized and used in device code. This change also reverts the address-space cast introduced in intel#1774 Signed-off-by: Premanand M Rao <[email protected]>
Signed-off-by: Premanand M Rao <[email protected]>
Fznamznon
previously approved these changes
Jul 6, 2020
Signed-off-by: Premanand M Rao <[email protected]>
Fznamznon
approved these changes
Jul 6, 2020
bader
changed the title
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Remove superfluous namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…initialized
Const static data members need to be either zero-initialized or
constant-initialized. We were emitting all const static data
members before, which needed address space casts from constant-space
to private-space.
This change also reverts the address-space cast introduced in
#1774
Signed-off-by: Premanand M Rao [email protected]