-
Notifications
You must be signed in to change notification settings - Fork 769
Adding buffer_location SPIR-V spec as an extension #2084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
121 changes: 121 additions & 0 deletions
121
sycl/doc/extensions/SPIRV/SPV_INTEL_fpga_buffer_location.asciidoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,121 @@ | ||
SPV_INTEL_fpga_buffer_location | ||
============================== | ||
|
||
== Name Strings | ||
|
||
SPV_INTEL_fpga_buffer_location | ||
|
||
== Contact | ||
|
||
To report problems with this extension, please open a new issue at: | ||
|
||
https://github.com/KhronosGroup/SPIRV-Headers | ||
|
||
== Contributors | ||
|
||
- Joe Garvey, Intel + | ||
|
||
== Notice | ||
|
||
Copyright (c) 2019-2020 Intel Corporation. All rights reserved. | ||
|
||
== Status | ||
|
||
Draft | ||
|
||
== Version | ||
|
||
[width="40%",cols="25,25"] | ||
|======================================== | ||
| Last Modified Date | {docdate} | ||
| Revision | A | ||
|======================================== | ||
|
||
== Dependencies | ||
|
||
This extension is written against the SPIR-V Specification, | ||
Version 1.5 Revision 2. | ||
|
||
This extension requires SPIR-V 1.0. | ||
|
||
== Overview | ||
|
||
This extension adds a function parameter decoration that is useful for FPGA targets. This decoration indicates that a particular global memory pointer can only access a particular physical memory location. Knowing this information at compile time can allow FPGA compilers to generate load store units of lower area for accesses done through such a pointer. | ||
|
||
== Extension Name | ||
To use this extension within a SPIR-V module, the following *OpExtension* must be present in the module: | ||
|
||
---- | ||
OpExtension "SPV_INTEL_fpga_buffer_location" | ||
---- | ||
|
||
== New Capabilities | ||
This extension introduces a new capability: | ||
|
||
---- | ||
FPGABufferLocationINTEL | ||
---- | ||
|
||
== Token Number Assignments | ||
|
||
-- | ||
[width="40%"] | ||
[cols="70%,30%"] | ||
[grid="rows"] | ||
|==== | ||
|FPGABufferLocationINTEL |5920 | ||
|BufferLocationINTEL |5921 | ||
|==== | ||
-- | ||
|
||
== Modifications to the SPIR-V Specification, Version 1.5 | ||
|
||
=== Decoration | ||
|
||
Modify Section 3.20, Decoration, adding these rows to the Decoration table: | ||
|
||
-- | ||
[options="header"] | ||
|==== | ||
2+^| Decoration | Extra Operands | Enabling Capabilities | ||
| 5921 | *BufferLocationINTEL* + | ||
Apply to a pointer *OpFunctionParameter*. Indicates that the pointer may only point into the physical memory indentified by the subsequent literal number operand. | Literal + | ||
_Buffer Location ID_ | *FPGABufferLocationINTEL* | ||
|==== | ||
-- | ||
|
||
=== Capability | ||
|
||
Modify Section 3.31, Capability, adding a row to the Capability table: | ||
-- | ||
[options="header"] | ||
|==== | ||
2+^| Capability ^| Implicitly Declares | ||
| 5920 | FPGABufferLocationINTEL | | ||
|==== | ||
-- | ||
|
||
=== Validation Rules | ||
|
||
None. | ||
|
||
== Issues | ||
|
||
None. | ||
|
||
//. Issue. | ||
//+ | ||
//-- | ||
//*RESOLVED*: Resolution. | ||
//-- | ||
|
||
== Revision History | ||
|
||
[cols="5,15,15,70"] | ||
[grid="rows"] | ||
[options="header"] | ||
|======================================== | ||
|Rev|Date|Author|Changes | ||
|A|2019-11-21|Joe Garvey|*Initial internal draft* | ||
|B|2020-04-08|Joe Garvey|*Reworked to be a decoration instead of a function attribute and made the spec specific to buffer location* | ||
|======================================== |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.