[SYCL] Allow recursive function calls in a constexpr context. #2105
Conversation
It doesn't really make sense to restrict recursion for something that is forced to be evaluated at constexpr time, since this is a restriction due to device limitations. This patch creates a constexpr-context count for all of the constexpr contexts I could create, and creates a counter. It is implemented this way to permit a future implementer to add other diagnostics (such as DLLImport?) as permissible in constexpr.
erichkeane
requested review from
elizabethandrews,
Fznamznon and
premanandrao
as code owners
|
Ping @premanandrao I think the other two are on vacation today :) Also, I've got no idea on the Jenkins failure, it claims that test_hierarchical_opencl failed, yet there is nothing in this patch that could have caused that. |
I'm working till noon to attend your training today!
I didn't see this fail. The links led me to this failing test - |
|
LGTM but @premanandrao can you also take a look? |
I thought I had approved it yesterday. :-) |
It doesn't really make sense to restrict recursion for something that is
forced to be evaluated at constexpr time, since this is a restriction
due to device limitations. This patch creates a constexpr-context count
for all of the constexpr contexts I could create, and creates a counter.
It is implemented this way to permit a future implementer to add other
diagnostics (such as DLLImport?) as permissible in constexpr.
This was requested in #2104