[SYCL] Add a test for wrapped pointer kernel args #2298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before structs decomposition USM pointers that are wrapped by structs were passsed with generic address space. It caused performance issues. After structs decomposition all pointers are passed with global address space, this test is added to save this behaviour.
Fznamznon
requested review from
elizabethandrews and
premanandrao
as code owners
jsji
pushed a commit
that referenced
this pull request
Jan 25, 2024
Partially load SPIR-V from the stream and decode only selected for the report instructions, needed to retrieve general information about the module: capabilities, extensions, version, memory model and addressing model. In addition to immediately helpful for back-ends lists of capabilities and extensions declared in SPIR-V module, a general intent also is to extend report details in future by feedbacks about further potentially useful analysis, statistics, etc. Original commit: KhronosGroup/SPIRV-LLVM-Translator@918036c
jsji
pushed a commit
that referenced
this pull request
Feb 1, 2024
The goal of the PR is to add API to SPIR-V LLVM Translator to query error message by an error code as discussed in #2298 A need and possible application is a way to generate human-readable error info by error codes returned by other SPIRV Translator API calls, including getSpirvReport(). Original commit: KhronosGroup/SPIRV-LLVM-Translator@afe1971
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
Improve CUDA/HIP local argument handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before structs decomposition USM pointers that are wrapped by structs
were passsed with generic address space. It caused performance issues.
After structs decomposition all pointers are passed with global address
space, this test is added to save this behaviour.